After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773641 - vala-pack: implement various :load() vfuncs
vala-pack: implement various :load() vfuncs
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-28 16:37 UTC by Georges Basile Stavracas Neto
Modified: 2016-10-28 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vala-pack: implement various :load() vfuncs (1.80 KB, patch)
2016-10-28 16:37 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Georges Basile Stavracas Neto 2016-10-28 16:37:29 UTC 
The Vala compiler is complaining about some vala-pack classes not
overriding the :load() vfuncs.

Fix that by adding stub implementations of them.
Comment 1 Georges Basile Stavracas Neto 2016-10-28 16:37:33 UTC 
Created attachment 338740 [details] [review]
vala-pack: implement various :load() vfuncs
Comment 2 Christian Hergert 2016-10-28 18:50:28 UTC 
Review of attachment 338740 [details] [review]:

Interesting. Would be good to know what we need to add to get Vala to understand its an optional override.
Comment 3 Georges Basile Stavracas Neto 2016-10-28 18:54:32 UTC 
Thanks for the review!

Attachment 338740 [details] pushed as fc1e480 - vala-pack: implement various :load() vfuncs