After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773640 - rtspclient unit test failures
rtspclient unit test failures
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal blocker
: 1.8.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-28 16:03 UTC by Tim-Philipp Müller
Modified: 2016-11-02 11:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: try to avoid using the same ports in different tests (3.61 KB, patch)
2016-10-28 17:41 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2016-10-28 16:03:30 UTC
There are some rtsp-server unit test failures which are new.

Two rtspclient tests fail fairly frequently:
 - test_client_multicast_ignore_transport_specific
 - test_client_multicast_transport_specific

These are new failures apparently. They don't happen everytime, but often enough that they should be easy to reproduce. For me they only happen with 'make check', but not with 'make gst/client.check', why I don't know.

Running suite(s): rtspclient
84%: Checks: 13, Failures: 2, Errors: 0

gst/client.c:505:F:general:test_client_multicast_ignore_transport_specific:0: 'str' (RTP/AVP;multicast;destination=233.252.0.1;ttl=1;port=5004-5005;mode="PLAY") is not equal to 'expected_transport' (RTP/AVP;multicast;destination=233.252.0.1;ttl=1;port=5000-5001;mode="PLAY")

gst/client.c:494:F:general:test_client_multicast_transport_specific:0: 'code' (461) is not equal to 'GST_RTSP_STS_OK' (200)
FAIL gst/client (exit status: 2)
Comment 1 Tim-Philipp Müller 2016-10-28 16:17:54 UTC
git bisect seems to point towards:

commit e5a49efa7ffce2ca2eeefb1a8bad97edfc96649f
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Sep 6 19:10:21 2016 +0300

    rtsp-stream: Bind multicast sockets to ANY as before
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766612#c48
Comment 2 Tim-Philipp Müller 2016-10-28 16:43:39 UTC
> For me they only happen with 'make check', but not
> with 'make gst/client.check', why I don't know.

It looks like it's a bad interaction between multiple tests running at the same time.

Lots of tests use the same ports, so it's possible that the fact that it fails like this is not actually a bug in the patch but simply something that wasn't triggered because of the bug the patch fixes.

With 'make -j1 check' it always passes for me.

What to do? Fix up tests to use different port numbers perhaps?
Comment 3 Tim-Philipp Müller 2016-10-28 17:41:09 UTC
Created attachment 338742 [details] [review]
tests: try to avoid using the same ports in different tests

This seems to help. make torture passes.
Comment 4 Tim-Philipp Müller 2016-10-31 12:06:04 UTC
commit 9e7cafde5aa75c91836b41296b2e714d8f866f6c
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Oct 28 18:38:01 2016 +0100

    tests: try to avoid using the same ports in different tests
    
    Causes problems with client multicast tests otherwise if
    tests are run in parallel.
Comment 5 Tim-Philipp Müller 2016-11-02 11:37:09 UTC
picked into 1.8 as well.