GNOME Bugzilla – Bug 773568
meson: don't add_global_arguments when being built as a subproject
Last modified: 2016-11-11 16:59:39 UTC
add_global_arguments() fails the build when meson.is_subproject() is true.
Created attachment 338576 [details] [review] [PATCH gst-plugins-bad] meson: don't add_global_arguments when being built as a subproject
Created attachment 338577 [details] [review] [PATCH gst-plugins-base] meson: don't add_global_arguments when being built as a subproject
Created attachment 338578 [details] [review] [PATCH gst-plugins-good] meson: don't add_global_arguments when being built as a subproject
Created attachment 338579 [details] [review] [PATCH gstreamer] meson: don't add_global_arguments when being built as a subproject
This should be accompanied by a patch that adds these warnings to the meson.build in gst-build instead. I will also note that the list of warning disables isn't comprehensive, so if you have the time it would be nice to get a proper list that gets rid of all useless warnings (without compromising too much on legitimate warnings).
(In reply to Nirbheek Chauhan from comment #5) > This should be accompanied by a patch that adds these warnings to the > meson.build in gst-build instead. > > I will also note that the list of warning disables isn't comprehensive, so > if you have the time it would be nice to get a proper list that gets rid of > all useless warnings (without compromising too much on legitimate warnings). Yep, I also noticed that the warning list isn't exhaustive and had to turn of Werror. I'll come up with the full list of warnings to disable.
Comment on attachment 338579 [details] [review] [PATCH gstreamer] meson: don't add_global_arguments when being built as a subproject commit 03286b7b7ec1947c0117047c229c09917f575eb5 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Wed Oct 26 22:38:07 2016 -0700 meson: don't add_global_arguments when being built as a subproject https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment on attachment 338577 [details] [review] [PATCH gst-plugins-base] meson: don't add_global_arguments when being built as a subproject commit 9ce939a9ae889ca2e6198e595b6b8993282c0e59 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Wed Oct 26 22:37:19 2016 -0700 meson: don't add_global_arguments when being built as a subproject https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment on attachment 338578 [details] [review] [PATCH gst-plugins-good] meson: don't add_global_arguments when being built as a subproject commit 5a7c3429225a42982834f77d91e0ccb7d8879242 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Wed Oct 26 22:37:34 2016 -0700 meson: don't add_global_arguments when being built as a subproject https://bugzilla.gnome.org/show_bug.cgi?id=773568
Comment on attachment 338576 [details] [review] [PATCH gst-plugins-bad] meson: don't add_global_arguments when being built as a subproject commit ba2908aa2c28a50de84231e9f93ca9032f3eb608 Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Wed Oct 26 22:36:17 2016 -0700 meson: don't add_global_arguments when being built as a subproject https://bugzilla.gnome.org/show_bug.cgi?id=773568
There's https://github.com/mesonbuild/meson/pull/1030 now, so if we can get that into 0.36 we can just use that.