After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773563 - Add accelerators for keyboard navigation
Add accelerators for keyboard navigation
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: User Interface
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-27 01:02 UTC by Daniel Boles
Modified: 2017-03-01 21:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
edit-pane: add mnemonics for keyboard activation (4.21 KB, patch)
2016-10-27 01:21 UTC, Daniel Boles
none Details | Review
edit-pane: add mnemonics for keyboard activation (4.26 KB, patch)
2016-10-27 01:34 UTC, Daniel Boles
none Details | Review
[patch 2] ui: add mnemonics to other labelled buttons (5.78 KB, patch)
2016-10-27 01:37 UTC, Daniel Boles
committed Details | Review
edit-pane: add mnemonics for keyboard activation (4.47 KB, patch)
2016-10-27 01:48 UTC, Daniel Boles
none Details | Review
[patch 3] edit-pane: add key accelerator for due date popup (1.21 KB, patch)
2016-10-27 01:54 UTC, Daniel Boles
committed Details | Review
[patch 1] edit-pane: add mnemonics for keyboard activation (4.52 KB, patch)
2016-10-27 02:00 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2016-10-27 01:02:00 UTC
It would be great to be able to quickly set the date or delete the selected task without having to whoosh the pointer all the way over to the delete button.

There are probably also other areas where big gains can be made in keyboard accessibility.

Somewhat related: https://bugzilla.gnome.org/show_bug.cgi?id=767509
Comment 1 Daniel Boles 2016-10-27 01:21:25 UTC
Created attachment 338563 [details] [review]
edit-pane: add mnemonics for keyboard activation

    This makes the buttons and combobox keyboard accessible.
Comment 2 Daniel Boles 2016-10-27 01:34:37 UTC
Created attachment 338564 [details] [review]
edit-pane: add mnemonics for keyboard activation

add this bug URL
Comment 3 Daniel Boles 2016-10-27 01:37:24 UTC
Created attachment 338565 [details] [review]
[patch 2] ui: add mnemonics to other labelled buttons

This adds mnemonics for all the other labelled buttons I could see in the ui folder.

Of course, feel free to critique my chosen letters. I usually just use the first letter, but if that's ambiguous, I have to get creative.


I guess keyboard acceleration for image buttons would require actions and the like (as things like gtk_widget_add_accelerator do not seem to have a counterpart in ui definitions).
Comment 4 Daniel Boles 2016-10-27 01:48:08 UTC
Created attachment 338566 [details] [review]
edit-pane: add mnemonics for keyboard activation

Use _N for the Notes textview, rather than the far less useful None button in the date popup.
Comment 5 Daniel Boles 2016-10-27 01:54:32 UTC
Created attachment 338567 [details] [review]
[patch 3] edit-pane: add key accelerator for due date popup

I personally like this, but I can see how the distance between the label and the button it activates might seem unintuitive and am not 100% sure about the chosen letter - so I'll propose it separately.
Comment 6 Daniel Boles 2016-10-27 02:00:40 UTC
Created attachment 338568 [details] [review]
[patch 1] edit-pane: add mnemonics for keyboard activation

I keep losing the URLs in my commit messages...
Comment 7 Georges Basile Stavracas Neto 2017-03-01 21:19:55 UTC
Review of attachment 338565 [details] [review]:

LGTM
Comment 8 Georges Basile Stavracas Neto 2017-03-01 21:20:12 UTC
Review of attachment 338568 [details] [review]:

LGTM
Comment 9 Georges Basile Stavracas Neto 2017-03-01 21:20:24 UTC
Review of attachment 338567 [details] [review]:

LGTM
Comment 10 Georges Basile Stavracas Neto 2017-03-01 21:21:28 UTC
Thanks for the patches!