GNOME Bugzilla – Bug 773563
Add accelerators for keyboard navigation
Last modified: 2017-03-01 21:21:38 UTC
It would be great to be able to quickly set the date or delete the selected task without having to whoosh the pointer all the way over to the delete button. There are probably also other areas where big gains can be made in keyboard accessibility. Somewhat related: https://bugzilla.gnome.org/show_bug.cgi?id=767509
Created attachment 338563 [details] [review] edit-pane: add mnemonics for keyboard activation This makes the buttons and combobox keyboard accessible.
Created attachment 338564 [details] [review] edit-pane: add mnemonics for keyboard activation add this bug URL
Created attachment 338565 [details] [review] [patch 2] ui: add mnemonics to other labelled buttons This adds mnemonics for all the other labelled buttons I could see in the ui folder. Of course, feel free to critique my chosen letters. I usually just use the first letter, but if that's ambiguous, I have to get creative. I guess keyboard acceleration for image buttons would require actions and the like (as things like gtk_widget_add_accelerator do not seem to have a counterpart in ui definitions).
Created attachment 338566 [details] [review] edit-pane: add mnemonics for keyboard activation Use _N for the Notes textview, rather than the far less useful None button in the date popup.
Created attachment 338567 [details] [review] [patch 3] edit-pane: add key accelerator for due date popup I personally like this, but I can see how the distance between the label and the button it activates might seem unintuitive and am not 100% sure about the chosen letter - so I'll propose it separately.
Created attachment 338568 [details] [review] [patch 1] edit-pane: add mnemonics for keyboard activation I keep losing the URLs in my commit messages...
Review of attachment 338565 [details] [review]: LGTM
Review of attachment 338568 [details] [review]: LGTM
Review of attachment 338567 [details] [review]: LGTM
Thanks for the patches!