After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773551 - Stop including unstable DOM API headers
Stop including unstable DOM API headers
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-26 18:11 UTC by Michael Catanzaro
Modified: 2017-06-20 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require WebKitGTK+ 2.15.1 (635 bytes, patch)
2016-10-26 18:11 UTC, Michael Catanzaro 		committed Details | Review
web-extension: Stop using unstable DOM API headers (1.21 KB, patch)
2016-10-26 18:11 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2016-10-26 18:11:46 UTC 
Yelp no longer needs to depend on unstable WebKit API. Distributions can confidently package Yelp without worrying that the ABI it depends on will unexpectedly change.
Comment 1 Michael Catanzaro 2016-10-26 18:11:49 UTC 
Created attachment 338539 [details] [review]
Require WebKitGTK+ 2.15.1
Comment 2 Michael Catanzaro 2016-10-26 18:11:53 UTC 
Created attachment 338540 [details] [review]
web-extension: Stop using unstable DOM API headers

It's undesirable for Yelp to live on the edge, depending on API/ABI that
can change at any time, without us noticing, without any WebKit soname
bump. So the unstable API has been removed from WebKit. All API needed
by Yelp is now stable.

And there was much rejoicing in the streets!
Comment 3 Carlos Garcia Campos 2016-10-27 15:24:04 UTC 
The unstable headers used by yelp will not be removed, we will keep them for backwards compatibility until we bump the ABI version. In any case, if you bump the WebKitGTK+ required version you can of course remove the includes.
Comment 4 Jeremy Bicha 2017-02-06 12:25:45 UTC 
Please see bug 778240
Comment 5 David King 2017-06-20 10:34:20 UTC 
Review of attachment 338539 [details] [review]:

Pushed to master as commit 89987e4996ae2490ee496ab1c887c02988dbab93.
Comment 6 David King 2017-06-20 10:34:39 UTC 
Review of attachment 338540 [details] [review]:

Pushed to master as commit 344986463565dd6ab51d4ef3ebec52b5880817e8.