GNOME Bugzilla – Bug 773518
rtpvp8pay: Fix allocation to support source-info property
Last modified: 2018-11-03 15:13:23 UTC
Use gst_rtp_base_payload_allocate_output_buffer() in order to allocate RTP buffer with correct number of CSRCs according to the meta.
Created attachment 338482 [details] [review] rtpvp8pay: Fix allocation to support source-info property
Dependency added since this patch makes use of the new functionality added in the other patch.
Comment on attachment 338482 [details] [review] rtpvp8pay: Fix allocation to support source-info property What does this fix, what effects does it have and how would things fail otherwise? :) Also who would add the meta other than the depayloader, so this only matters for depay!pay?
I've updated bug 761947 address the general use for adding CSRCs. The patch in bug 761947 adds the property source-info to all payloaders to make them aware of the proposed RTPSourceMeta. But for the payloader to actually add the CSRCs it must use gst_rtp_base_payload_allocate_output_buffer() to allocate a properly sized RTP buffer and fill the CSRCs from to the meta. By not using gst_rtp_base_payload_allocate_output_buffer() the payloader will not add CSRCs even when the property source-info is TRUE.
Comment on attachment 338482 [details] [review] rtpvp8pay: Fix allocation to support source-info property Ok, and patches are also needed for all the other (de)payloaders then I guess?
Comment on attachment 338482 [details] [review] rtpvp8pay: Fix allocation to support source-info property Good to go once the other patch is in
Created attachment 339242 [details] [review] rtpvp8pay: Fix allocation to support source-info property Update patch to use the correct csrc_count when finding the max payload length.
When this is in I will go through other payloaders as well.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/314.