After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773510 - speexenc: Fix segment before caps event when draining
speexenc: Fix segment before caps event when draining
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-26 07:53 UTC by Stian Selnes (stianse)
Modified: 2018-11-03 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
speexenc: Fix segment before caps event when draining (3.15 KB, patch)
2016-10-26 07:53 UTC, Stian Selnes (stianse) 		reviewed Details | Review

Description Stian Selnes (stianse) 2016-10-26 07:53:15 UTC 
Don't send a segment event if we haven't produced data and set the
output caps yet. Doing so causes a g_warning about sticky event
misordering.
Comment 1 Stian Selnes (stianse) 2016-10-26 07:53:20 UTC 
Created attachment 338476 [details] [review]
speexenc: Fix segment before caps event when draining
Comment 2 Sebastian Dröge (slomo) 2016-10-26 08:12:32 UTC 
Comment on attachment 338476 [details] [review]
speexenc: Fix segment before caps event when draining

speexenc updating a segment, or in general sending a segment event at all, seems problematic. See also https://bugzilla.gnome.org/show_bug.cgi?id=768763 for another example of why that's usually not a good idea.

Maybe that should be removed all together?
Comment 3 GStreamer system administrator 2018-11-03 15:13:16 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/313.