After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773482 - [RFE] split PPP support into a separate package
[RFE] split PPP support into a separate package
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Beniamino Galvani
NetworkManager maintainer(s)
Depends on:
Blocks: 559134 nm-next
 
 
Reported: 2016-10-25 14:12 UTC by Thomas Haller
Modified: 2016-12-06 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-10-25 14:12:17 UTC 
currently, NetworkManager package require ppp (even if the user doesn't use it).

This should be split out in a separate plugin.


Note related bug 559134 which asks for improving ppp support in general. This is about allowing to drop the ppp dependency from core pacakge.
Comment 1 Beniamino Galvani 2016-11-08 14:53:41 UTC 
How about branch bg/ppp-split-bgo773482?

Alternatively we could split the whole ppp-manager to a new NM plugin and let it register some ppp-manager ops into the core when it is loaded. But the complication of having a new generic plugin infrastructure probably is not worth the gain - the NetworkManager-ppp Fedora package would be only ~30KiB saved from the main package. Proof of concept in branch bg/ppp-manager-split-bgo773482.
Comment 2 Thomas Haller 2016-11-08 15:20:31 UTC 
+Obsoletes: NetworkManager < 1.6.0

could we have a

 %global obsoletes_device_plugins 1:0.9.9.95-1
+%global obsoletes_ppp_plugin     1.6.0




I think Obsoletes also needs a Provides, no? Lubomir?



>> core: move plugin path reading function to nm-core-utils.c

I anyway like this commit. Should be done.

did you investigate whether it's possible to load the ppp-manager plugin on demand? Then it would make much more sense.

30KiB is worth it, if it is saved by all users who don't use PPP. It is less worth it, if it only affects all users who didn't install NM-ppp package.
Comment 3 Beniamino Galvani 2016-11-18 17:19:27 UTC 
(In reply to Thomas Haller from comment #2)
> +Obsoletes: NetworkManager < 1.6.0
> 
> could we have a
> 
>  %global obsoletes_device_plugins 1:0.9.9.95-1
> +%global obsoletes_ppp_plugin     1.6.0

Ok (changed to 1.5.x).

> I think Obsoletes also needs a Provides, no? Lubomir?

I have no idea.

> >> core: move plugin path reading function to nm-core-utils.c
> 
> I anyway like this commit. Should be done.
> 
> did you investigate whether it's possible to load the ppp-manager plugin on
> demand? Then it would make much more sense.
> 
> 30KiB is worth it, if it is saved by all users who don't use PPP. It is less
> worth it, if it only affects all users who didn't install NM-ppp package.

Updated branch bg/ppp-manager-split-bgo773482 to do demand loading of the plugin.
Comment 4 Thomas Haller 2016-11-20 23:22:47 UTC 
pushed some fixups, the latest one is a larger change.

What do you say?



I like the branch. Yeah, it saves only 16kb in NetworkManager binary (although libnm-ppp-plugin.so is 44K). Still, I think it makes sense because many uses of NM do not involve actually creating a NMPPPManager instance.
Comment 5 Beniamino Galvani 2016-11-29 14:55:52 UTC 
(In reply to Thomas Haller from comment #4)
> pushed some fixups, the latest one is a larger change.
> 
> What do you say?

LGTM. Since the Makefile and ppp-manager path changed in the meanwhile on master, I have squashed all the fixups, rebased and pushed everything to branch bg/ppp-manager-split-bgo773482-squashed.
Comment 6 Thomas Haller 2016-11-29 15:10:12 UTC 
still lgtm