After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773466 - Server: Do not transmit unplayable rhythmdb entries to the DMAP client
Server: Do not transmit unplayable rhythmdb entries to the DMAP client
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: DAAP
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-25 10:08 UTC by gnome.vrb
Modified: 2016-10-25 11:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[patch] Do not transmit unplayable rhythmdb entries to the DMAP client (1.16 KB, patch)
2016-10-25 10:34 UTC, gnome.vrb 		committed Details | Review

Description gnome.vrb 2016-10-25 10:08:00 UTC 
Forked off from https://bugzilla.gnome.org/show_bug.cgi?id=773400.

Currently, "Missing Files" in the DAAP server are listed in the DAAP client. Clicking on the entries in the client, results in the following error in the server.

(rhythmbox:16746): libdmapsharing-WARNING **: Couldn't open file:///media/sf_dev/temp/Hans%20Zimmer/The%20Dark%20Knight%20Rises_%20Original%20Motion%20Picture%20Soundtrack/11%20Why%20Do%20We%20Fall_%201.mp3: Error opening file /media/sf_dev/temp/Hans Zimmer/The Dark Knight Rises_ Original Motion Picture Soundtrack/11 Why Do We Fall_ 1.mp3: No such file or directory.

The missing entries should not be transmitted to the client, in the first place.
Comment 1 gnome.vrb 2016-10-25 10:34:44 UTC 
Created attachment 338393 [details] [review]
[patch] Do not transmit unplayable rhythmdb entries to the DMAP client
Comment 2 Jonathan Matthew 2016-10-25 11:35:25 UTC 
Review of attachment 338393 [details] [review]:

pushed with some changes as commit 04c30b9

::: plugins/daap/rb-rhythmdb-dmap-db-adapter.c
@@ +69,3 @@
 	DMAPRecord *record;
 	ForeachAdapterData *foreach_adapter_data;
+	gchar *playback_uri;

this should not be a gchar pointer

@@ +71,3 @@
+	gchar *playback_uri;
+
+	/* Skip hidden entries */

useless comment

@@ +75,3 @@
+		return;
+
+	/* Skip entries with no playback uri */

useless comment