After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773449 - exported animated webp images play layers in reverse
exported animated webp images play layers in reverse
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-10-25 02:08 UTC by triune
Modified: 2016-10-25 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix for webp animation order (1.65 KB, patch)
2016-10-25 13:14 UTC, pascal.massimino
none Details | Review
fix for animation order during webp saving (1.56 KB, patch)
2016-10-25 13:28 UTC, pascal.massimino
committed Details | Review

Description triune 2016-10-25 02:08:12 UTC
To reproduce:
1) Open any animated image (webp/gif/etc)
2) The opened image must have multiple layers (as multiple frames of animation)
3) Export the file as webp and choose the animation option

Results:
The steps in the animation play from the top layer to the bottom layer (background) which is the reverse of what it should be. 

Expected Results:
If you export a GIF in step #3 above, the animated GIF will play from bottom layer to top layer (correct order).

More information:
I am using git 2.9.5 (commit bafe441) from the Otto PPA running Ubuntu 16.04.1
Comment 2 pascal.massimino 2016-10-25 13:05:28 UTC
i can reproduce with fresh TOT.
Having a look at a potential fix.
Comment 3 pascal.massimino 2016-10-25 13:14:50 UTC
Created attachment 338402 [details] [review]
fix for webp animation order
Comment 4 pascal.massimino 2016-10-25 13:15:28 UTC
the attached patch restores the proper saving order. Please have a look!
Comment 5 triune 2016-10-25 13:22:10 UTC
Thank you @Pascal ... your promptness in dealing with this is incredible! Unfortunately, I don't know how to (and am generally not interested in learning how to) build GIMP from source. So, I won't be able to test this until 2.9.6 hits the Otto PPA (assuming your patch lands before that is released).
Comment 6 pascal.massimino 2016-10-25 13:28:50 UTC
Created attachment 338412 [details] [review]
fix for animation order during webp saving

this patch uses gint32 instead of 'int'.
Comment 7 Michael Schumacher 2016-10-25 13:30:35 UTC
If it obsoletes the previous patch, it would be nice if you could mark that one as such.
Comment 8 pascal.massimino 2016-10-25 13:34:03 UTC
Comment on attachment 338402 [details] [review]
fix for webp animation order

is actually obsolete
Comment 9 pascal.massimino 2016-10-25 13:36:12 UTC
#7: done, i didn't know one could mark a patch obsolete.
Comment 10 Jehan 2016-10-25 15:21:28 UTC
Review of attachment 338412 [details] [review]:

Looks good. Committed as:

commit 26a6a39b6b4de6083f82c3f5c5786ea14bbabc93
Author: Pascal Massimino <pascal.massimino@gmail.com>
Date:   Tue Oct 25 15:12:07 2016 +0200

    fix animation layer order when saving as webp

 plug-ins/file-webp/file-webp-save.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 11 Jehan 2016-10-25 15:22:55 UTC
Thanks for the bug report and the patch! :-)