GNOME Bugzilla – Bug 773447
Clean up permissions request handling
Last modified: 2016-11-07 04:24:11 UTC
All WebKitUserMediaPermissionRequests are denied, so users cannot give websites access to webcams or microphones. I wonder how did WebKitUserMediaPermissionRequest get added at all without being implemented in Epiphany. :( All WebKitInstallMissingMediaPluginsPermissionRequests are ignored. We should display an info bar offering to install the needed codecs. There should be an ignore button saved in the global GSettings (not per-host). Geolocation permission requests are not remembered on a per-host basis, as notification requests are. It should use EphyHostManager. This all requires modifying permission_request_cb in ephy-web-view.c. Pick any one of the above tasks and you have a good project for a newcomer.
(In reply to Michael Catanzaro from comment #0) > All WebKitInstallMissingMediaPluginsPermissionRequests are ignored. We > should display an info bar offering to install the needed codecs. There > should be an ignore button saved in the global GSettings (not per-host). See: https://bugs.webkit.org/show_bug.cgi?id=147822 Fixed the rest (hopefully)
The following fixes have been pushed: be02176 hosts-manager: Simplify 81233eb Allow sites to request access to webcam/microphone 6c66f18 web-view: Split info bar creation into separate function 1925829 Remember geolocation permission requests 8896421 web-view: Don't destroy info bar twice bce147a Switch hosts manager to use a multiplexing API e4acc12 hosts-manager: Fix code style
Created attachment 339212 [details] [review] hosts-manager: Simplify I realized I was being stupid, and have corrected this infraction.
Created attachment 339213 [details] [review] Allow sites to request access to webcam/microphone This is not tested at all since I don't want to context switch to my laptop. It probably works. Users should complain if not.
Created attachment 339214 [details] [review] web-view: Split info bar creation into separate function
Created attachment 339215 [details] [review] Remember geolocation permission requests Just like we do notification permission requests
Created attachment 339216 [details] [review] web-view: Don't destroy info bar twice
Created attachment 339217 [details] [review] Switch hosts manager to use a multiplexing API This is more scalable and is needed to avoid code duplication in EphyWebView
Created attachment 339218 [details] [review] hosts-manager: Fix code style