After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773380 - new feature update and pull request for CJKV
new feature update and pull request for CJKV
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-23 13:51 UTC by Seong-ho, Cho
Modified: 2016-10-30 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Korean Alphabet(Hangul) and Vietnamese Pronunciation. (62.65 KB, patch)
2016-10-23 18:25 UTC, DaeHyun Sung
none Details | Review

Description Seong-ho, Cho 2016-10-23 13:51:38 UTC
Hello, I'm a Korean translator of GNOME project, translationproject.org and any other popular desktop project, I heard from my local friend that new commit has submitted(suggested) into the gucharmap "mirror"(.........)

https://github.com/GNOME/gucharmap/pull/1/files

For abstracting a long description in a link, this commit will show what Han-ideograph could be pronounced depending on sprachraum, so we can  understand diversity of Han-ideograph pronunciation.
and, according to his individual saying, gucharmap has some old code applied, looks like misunderstanding about Korean character encoding, and there didn't seem to try improve this problem, doesn't following unicode consortium recommendation until now. 

so he fixed for,

1) Vietnamese
2) Han-Ideograph
3) Korean character encoding

I think that this pull request has 'beautiful feature' for many asian, so I recommend maintainer to consider to merge this pull request into the master. If it cannot be merged(due to any reason), tell us 'formal' way of process to submit patch(or simple link is also ok).

Another detailed answer for any question can get from him author.

Thank you.
Comment 1 Christian Persch 2016-10-23 16:24:37 UTC
I don't see a way on github to get that as a simple patch; if you know how, could you attach it here please?
Comment 2 DaeHyun Sung 2016-10-23 18:23:27 UTC
forked Github Repository: https://github.com/studioego/gucharmap 



Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.

Unihan_Readings.txt included in Unihan.zip defines the notation and pronunciation of East Asian languages such as Chinese, Japanese, Korean, Vietnamese.
Unihan_Readings.txt’ has some properties.
Such as
kCantonese, kDefinition, kHangul, kHanyuPinlu, kHanyuPinyin, kJapaneseKun, kJapaneseOn, kKorean, kMandarin, kTang, kVietnamese, kXHC1983.

I add Unihan_Readings.txt defined kVietnamese property and kHangul property in this program.

Unihan_Readings.txt’s property kVietnamese describe Vietnamese character(Quốc ngữ) pronunciation. this property defined Unihan version 3.1.1. Now Unihan database version is 9.0.0.
Unihan_Readings.txt’s property kHangul describe Korean character(한글,Hangul) describe Korean pronunciation for this character in hangul.(Hangul is Korean Alphabet) this property defined Unihan version 5.0. Now Unihan database version is 9.0.0.

1. Why do I add kHangul(Korean Alphabet[Hangul]) property?
Because, Unicode Consortium presented kHangul property on Unihan version 5.
Unicode Unihan database document ( http://www.unicode.org/reports/tr38/  ) describe “kKorean” property.
“kKorean property’s description”
The Korean pronunciation(s) of this character, using the Yale romanization system. (See <http://en.wikipedia.org/wiki/Korean_romanization> for a discussion of the various Korean romanization systems.)
Use of the kKorean field is not recommended. The kHangul field, which is aligned to the KS X 1001 and KS X 1002 standards, is recommended to be used instead.

Now, Revised Romanization of Korean (RR, also called South Korean or Ministry of Culture (MC) 2000)  is the most commonly used and widely accepted system of romanization for Korean instead of "Yale romanization system"[kKorean property] in Unihan database.

So,  I add kHangul property and add “Korean Alphabet(Hangul)” notation.

2. Why do i add kVietnamese(Vietnamese pronunciation[Quốc ngữ]) property?
“Unicode Consortium’s version9 guide chapter18. East Asia shows these paragraph.
In Vietnam, a set of native ideographs was created for Vietnamese based on the same principles used to create new ideographs for Chinese. These Vietnamese ideographs were used through the beginning of the 20th century and are occasionally used in more recent signage and other limited contexts.

Although the term “CJK”—Chinese, Japanese, and Korean—is used throughout this text to describe the languages that currently use Han ideographic characters, it should be noted that earlier Vietnamese writing systems were based on Han ideographs. Consequently, the term “CJKV” would be more accurate in a historical sense. Han ideographs are still used for historical, religious, and pedagogical purposes in Vietnam. “

So I read Unihan documentation specification, then  support Vietnamese language.
Comment 3 DaeHyun Sung 2016-10-23 18:25:45 UTC
Created attachment 338297 [details] [review]
Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.

Forked My Github repository: https://github.com/studioego/gucharmap
Refer Link: https://github.com/GNOME/gucharmap/pull/1

Unihan_Readings.txt included in Unihan.zip defines the notation and pronunciation of East Asian languages such as Chinese, Japanese, Korean, Vietnamese.
Unihan_Readings.txt’ has some properties.
Such as
kCantonese, kDefinition, kHangul, kHanyuPinlu, kHanyuPinyin, kJapaneseKun, kJapaneseOn, kKorean, kMandarin, kTang, kVietnamese, kXHC1983.

I add Unihan_Readings.txt defined kVietnamese property and kHangul property in this program.

Unihan_Readings.txt’s property kVietnamese describe Vietnamese character(Quốc ngữ) pronunciation. this property defined Unihan version 3.1.1. Now Unihan database version is 9.0.0.
Unihan_Readings.txt’s property kHangul describe Korean character(한글,Hangul) describe Korean pronunciation for this character in hangul.(Hangul is Korean Alphabet) this property defined Unihan version 5.0. Now Unihan database version is 9.0.0.

    Why do I add kHangul(Korean Alphabet[Hangul]) property? Because, Unicode Consortium presented kHangul property on Unihan version 5. Unicode Unihan database document ( http://www.unicode.org/reports/tr38/ ) describe “kKorean” property. “kKorean property’s description” The Korean pronunciation(s) of this character, using the Yale romanization system. (See http://en.wikipedia.org/wiki/Korean_romanization for a discussion of the various Korean romanization systems.) Use of the kKorean field is not recommended. The kHangul field, which is aligned to the KS X 1001 and KS X 1002 standards, is recommended to be used instead.

Now, Revised Romanization of Korean (RR, also called South Korean or Ministry of Culture (MC) 2000) is the most commonly used and widely accepted system of romanization for Korean instead of "Yale romanization system"[kKorean property] in Unihan database.

So, I add kHangul property and add “Korean Alphabet(Hangul)” notation.

    Why do i add kVietnamese(Vietnamese pronunciation[Quốc ngữ]) property? “Unicode Consortium’s version9 guide chapter18. East Asia shows these paragraph. In Vietnam, a set of native ideographs was created for Vietnamese based on the same principles used to create new ideographs for Chinese. These Vietnamese ideographs were used through the beginning of the 20th century and are occasionally used in more recent signage and other limited contexts.

Although the term “CJK”—Chinese, Japanese, and Korean—is used throughout this text to describe the languages that currently use Han ideographic characters, it should be noted that earlier Vietnamese writing systems were based on Han ideographs. Consequently, the term “CJKV” would be more accurate in a historical sense. Han ideographs are still used for historical, religious, and pedagogical purposes in Vietnam. “

So I read Unihan documentation specification, then support Vietnamese language.
Comment 4 Christian Persch 2016-10-30 11:56:22 UTC
I've committed the patch, with only minor modification:
* Translations are omitted, since they're the l10n teams' resonsibility, I'm unable to review them
* I've removed using the kKorean in the charmap character details page, and only left the kHangul in, since UAX#38 recommends that.

This will be in the 9.0.2 release which is due soon.

Thanks!