After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773335 - Reinstate importer test
Reinstate importer test
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
1.46.x
Other All
: Normal enhancement
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-22 00:46 UTC by Philip Chimento
Modified: 2016-10-22 05:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Reinstate importer test (7.81 KB, patch)
2016-10-22 00:47 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2016-10-22 00:46:51 UTC 
While working on https://bugzilla.gnome.org/show_bug.cgi?id=742249 I wanted to make some changes to the importer. I discovered there were some data files still in the tree belonging to a testImporter.js that got removed when the test suite was converted to installed tests.

Now that it's possible to import modules from a resource:// URI, it's possible to reinstate that test.
Comment 1 Philip Chimento 2016-10-22 00:47:19 UTC 
Created attachment 338235 [details] [review]
tests: Reinstate importer test

Now that it's possible to import modules from resource:// URIs, we can
reinstate the importer test that got removed when the test suite was
converted to an installed test suite.

The resulting file is slightly different from the one that got removed in
[54538f3da91b25ed20c9deaeda00d57fb252227c]. In the intervening time,
importer objects have lost the ability to enumerate their properties, so
we remove the corresponding tests.

The importer test's data files were still hanging around in the source
tree anyway, so they get added to the jsunit GResource and EXTRA_DIST. We
remove a few that were only used in the importer enumeration tests.
Comment 2 Cosimo Cecchi 2016-10-22 02:19:43 UTC 
Review of attachment 338235 [details] [review]:

Sure
Comment 3 Philip Chimento 2016-10-22 05:08:39 UTC 
Attachment 338235 [details] pushed as 6a80c32 - tests: Reinstate importer test