After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773328 - screenShield: Only allow graphs to lift shield when locked
screenShield: Only allow graphs to lift shield when locked
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-21 17:01 UTC by Florian Müllner
Modified: 2016-10-24 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenShield: Only allow graphs to lift shield when locked (1.75 KB, patch)
2016-10-21 17:01 UTC, Florian Müllner 		committed Details | Review

Comment 1 Florian Müllner 2016-10-21 17:01:42 UTC 
Created attachment 338202 [details] [review]
screenShield: Only allow graphs to lift shield when locked

Since commit 67615a0cbc, any printable key can be used to lift the
screen shield rather than just escape/enter/space. While this is
convenient for unlocking where the input is forwarded to the password
entry, it is potentially dangerous when the screen is inactive but
not locked: If the user types her password, the first character will
lift the shield and the remaining input will go to the focused window.
To prevent this from happening, only allow printable keys when the
screen is actually locked and restrict the key presses that lift the
shield to the original set of escape/enter/space otherwise.
Comment 2 Ray Strode [halfline] 2016-10-21 17:28:47 UTC 
Review of attachment 338202 [details] [review]:

nice idea.
Comment 3 Florian Müllner 2016-10-21 20:22:31 UTC 
Attachment 338202 [details] pushed as 205880e - screenShield: Only allow graphs to lift shield when locked