Created attachment 338127 [details] [review]
build: Rename variable

We install both a (private) library and an executable called 'polari'.
For now, the executable is a symlink to a script rather than a compiled
binary, so we use the POLARI variable for the library's dependencies.
As we are about to change that, rename it to LIBPOLARI to free the name
for the executable.

Created attachment 338128 [details] [review]
build: Use a small C wrapper

Gjs' package module provides some convenience like automatically loading
resources and setting the correct WM_CLASS, however this requires apps
to follow the somehow problematic pattern of either using the App ID as
name of the main binary (which nobody does for the time being), or making
it a symlink to a script of that name. Unfortunately this pattern requires
special treatment in the build system (hello, meson), which then makes it
harder to support from IDEs (hello, builder). Instead, replace the current
launcher script with a small binary that runs the same code, but also
includes the required resources.

I dont feel competent enough to give a "review" per se here, but for what it's worth I have compiled and run polari with both of these patches applied on top of polari git master. I have also read the diffs and skimmed the code and nothing immediate springed to my eyes. :-)

Attachment 338127 [details] pushed as 4a60bf6 - build: Rename variable
Attachment 338128 [details] pushed as f5dce05 - build: Use a small C wrapper