After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773289 - Recognize opening hours "00:00-24:00" as "around the clock"
Recognize opening hours "00:00-24:00" as "around the clock"
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-20 20:12 UTC by Marcus Lundblad
Modified: 2016-10-21 07:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
translations: Recognize 00:00-24:00 for opening hours (1.20 KB, patch)
2016-10-20 20:13 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2016-10-20 20:12:58 UTC 
"00:00-24:00" as the value of "opening_hours" can be found, and currently we only handle special cases for "24/7" and "Mo-Su 00:00-24:00" where the "around the clock" string is shown in the place bubble.
As far as I can see (the specification is quite hairy, and a language grammer fully-blown) this should be a valid way to express opening hours.
So we should probably handle this.
Comment 1 Marcus Lundblad 2016-10-20 20:13:20 UTC 
Created attachment 338124 [details] [review]
translations: Recognize 00:00-24:00 for opening hours

Using 00:00-24:00 as value of the opening hours OSM tag
can be found, and seems to be valid as per the specification.
Treat this the same as "24/7" and "Mo-Su 00:00-24:00" and
show "around the clock".
Comment 2 Jonas Danielsson 2016-10-21 06:14:40 UTC 
Review of attachment 338124 [details] [review]:

LGTM
Comment 3 Marcus Lundblad 2016-10-21 07:16:50 UTC 
Attachment 338124 [details] pushed as 1595f81 - translations: Recognize 00:00-24:00 for opening hours