After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773254 - Improve GTask wrapping
Improve GTask wrapping
Status: RESOLVED OBSOLETE
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on: 693576 773250
Blocks:
 
 
Reported: 2016-10-20 07:26 UTC by Garrett Regier
Modified: 2018-01-10 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overrides: Improve GTask wrapping (1.62 KB, patch)
2016-10-20 07:27 UTC, Garrett Regier 		reviewed Details | Review
tests: Add tests for GTask (3.84 KB, patch)
2016-10-20 07:30 UTC, Garrett Regier 		none Details | Review
tests: Add tests for GTask v2 (6.67 KB, patch)
2016-10-20 17:55 UTC, Garrett Regier 		none Details | Review

Description Garrett Regier 2016-10-20 07:26:09 UTC 
The run_in_thread() and run_in_thread_sync() methods are a bit weird and PyGObject cannot use set_task_data().
Comment 1 Garrett Regier 2016-10-20 07:27:47 UTC 
Created attachment 338072 [details] [review]
overrides: Improve GTask wrapping

The run_in_thread() and run_in_thread_sync() methods difficult to use because set_task_data() cannot be used.
Comment 2 Garrett Regier 2016-10-20 07:30:04 UTC 
Created attachment 338073 [details] [review]
tests: Add tests for GTask

I had to test these standalone due to the missing the required dbus helper, can someone check that these work in the PyGObject test suite?

Standalone they work just fine.
Comment 3 Garrett Regier 2016-10-20 17:55:01 UTC 
Created attachment 338116 [details] [review]
tests: Add tests for GTask v2

This now includes tests for return_error(), cancellation and report_error().
Comment 4 Christian Hergert 2016-10-25 20:55:51 UTC 
Both patches look good to me.

Anyone else closer to the project mind ACKing?
Comment 5 Simon Feltman 2016-12-23 02:54:47 UTC 
Review of attachment 338072 [details] [review]:

Does task_data just show up as None? Won't this be an API break?
Comment 6 GNOME Infrastructure Team 2018-01-10 20:57:14 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pygobject/issues/125.