GNOME Bugzilla – Bug 773221
Fixes for win32 theme
Last modified: 2018-05-02 17:39:18 UTC
Created attachment 338017 [details] [review] 0001-Fix-tiny-fonts-in-win32-theme There are lots of brokenness in the win32 theme, These patches try to fix the worst offenders. They are tested on windows 7, with the default style.
Created attachment 338018 [details] [review] 0002-Fix-CSS-warnings-in-win32-theme
Created attachment 338019 [details] [review] 0003-win32-theme-Fix-scrollbars
Created attachment 338020 [details] [review] 0004-win32-theme-use-TS_TRUE-in-GetThemePartSize
Created attachment 338021 [details] [review] 0005-win32-theme-No-need-to-create-a-DC-for-GetThemePartS
Created attachment 338022 [details] [review] 0006-win32-theme-Fix-scale-widget
Created attachment 338023 [details] [review] 0007-gtkwin32theme-delete-if-0-code
Created attachment 338024 [details] [review] 0008-win32-theme-Fix-popup-window-decorations
Created attachment 338025 [details] [review] 0009-win32-theme-Fix-column-headers
Created attachment 338026 [details] [review] 0010-win32-theme-Fix-combobox
Created attachment 338027 [details] [review] 0011-win32-theme-Fix-tooltip-borders
Created attachment 338028 [details] Screenshot of the win32 theme
Created attachment 338030 [details] win32 theme with these patches
The patches were all merged into gtk-3-22, but not in master, considering its state of flux.
Created attachment 339034 [details] [review] 0001-win32-theme-Fix-levelbar-and-tweak-progressbar I have a few more patches, as the bug wasn't closed I'll attach them here. If this is not OK for you, tell me and I'll open another bug. Regards
Created attachment 339035 [details] [review] 0002-win32-theme-fix-disabled-GtkEntry-style
Created attachment 339036 [details] [review] 0003-win32-theme-Fix-notebook-tabs
Created attachment 339037 [details] [review] 0004-win32-theme-Fix-unfocused-window-buttons
Created attachment 339038 [details] [review] 0005-win32-theme-make-separator-visible-again
Created attachment 339039 [details] [review] 0006-win32-theme-delete-stray-paren There were a typo in one of the applied patches (0010-win32-theme-Fix-combobox)
Created attachment 339040 [details] [review] 0007-win32-theme-Draw-expander-arrow
(In reply to Jaime Velasco from comment #14) > I have a few more patches, as the bug wasn't closed I'll attach them here. Thanks for working on this. I use GTK+ on Windows a fair amount so am keen to see the win32 theme become more viable, and will try to apply and review these. (I am fine with Adwaita as I actually prefer my apps to look the same everywhere, but a native theme is nice to have.) Also, we should probably try to get these all into master, too. I don't think much has changed, or is planned to, on the CSS side there. Testing will show, anyway.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/687.