GNOME Bugzilla – Bug 773211
properties-window cleanups and improvements
Last modified: 2021-06-18 15:50:42 UTC
In all instances where I had touched the code for the properties window, I was not very pleased with the experience. I will look at what I can improve and attach patches here.
Created attachment 338002 [details] [review] properties-window: merge create_page_with_{h,v}box() The two functions are now nearly identical with the deprecation of Gtk{H,V}Box.
Created attachment 338003 [details] [review] properties-window: do not expand prompt separator Currently, when packing the separator for the prompt, it is expanded. That means that it can grow vertically as the window grows, creating a visually unappealing effect.
Created attachment 338252 [details] [review] properties-window: use g_file_get_relative_path() Currently, a custom function is used to achieve the same effect as one can with g_file_get_relative_path().
Created attachment 338253 [details] [review] properties-window: use NautilusFile utility functions where available Some functions used are implemented in NautilusFile and can be removed.
Review of attachment 338002 [details] [review]: oh yes, thanks!
Review of attachment 338003 [details] [review]: ugh, LGTM
Review of attachment 338252 [details] [review]: ::: src/nautilus-properties-window.c @@ +5532,3 @@ else { + g_autoptr (GFile) file_location; all g_autoptr should be initialized to NULL. @@ +5534,3 @@ + g_autoptr (GFile) file_location; + g_autoptr (GFile) icon_location; + g_autofree gchar *real_icon_uri; same for g_autofree
Review of attachment 338253 [details] [review]: ah yes ::: src/nautilus-properties-window.c @@ +4882,3 @@ + gboolean is_special; + + is_special = (file == NULL || not need for parenthesses
Created attachment 338338 [details] [review] properties-window: use g_file_get_relative_path() Currently, a custom function is used to achieve the same effect as one can with g_file_get_relative_path().
Created attachment 338339 [details] [review] properties-window: use NautilusFile utility functions where available Some functions used are implemented in NautilusFile and can be removed.
Review of attachment 338338 [details] [review]: yeah
Review of attachment 338339 [details] [review]: +1
Attachment 338002 [details] pushed as fa86719 - properties-window: merge create_page_with_{h,v}box() Attachment 338003 [details] pushed as f56bc51 - properties-window: do not expand prompt separator Attachment 338338 [details] pushed as 014ba7a - properties-window: use g_file_get_relative_path() Attachment 338339 [details] pushed as bb00273 - properties-window: use NautilusFile utility functions where available
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Files (nautilus), then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/nautilus/-/issues/ Thank you for your understanding and your help.