GNOME Bugzilla – Bug 773180
Don't second-guess whether our GDK GL context is GLES
Last modified: 2016-10-23 20:27:12 UTC
Created attachment 337967 [details] [review]
We've already set ->use_es correctly at context creation time, all this can possibly do is change our mind about what kind of GL we're using.
Review of attachment 337967 [details] [review]:
The original idea — which I never got around to implement — was to make use-es a tri-state:
* -1: use epoxy_is_desktop_gl() (default)
* 0: use desktop GL
* 1: use GLES
This would at least allow some sort of auto-detection for GTK+ applications that do not have a configure-time setting that decides which GL API to use.
Created attachment 338016 [details] [review]
gdk/gl: Allow autodetection for GL/GLES
If the GdkGLContext was not explicitly instructed to use or not GLES, we
can detect whether the underlying API is going to be desktop GL or GLES.
Attachment 338016 [details] pushed as b878ec7 - gdk/gl: Allow autodetection for GL/GLES
Created attachment 338302 [details] [review]
gdk/gl: fix truth value of negative use_es
The introduction of negative use_es values in https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=803362bb5d376613d671eb84f1ca642259158e20 had some unexpected side effectes: Negative use_es evaluate to true when they shouldn't.
Not sure whether this patch really does what we want, but it makes GLAreas work again.
(In reply to Lukas from comment #5)
> Created attachment 338302 [details] [review] [review]
> gdk/gl: fix truth value of negative use_es
Thanks, but it would be best to have a separate bug report.
See bug 773397.