After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773165 - videodecoder: add _allocate_output_frame_with_params() to pass custom GstBufferPoolAcquireParams [API]
videodecoder: add _allocate_output_frame_with_params() to pass custom GstBuff...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 755072
 
 
Reported: 2016-10-18 15:54 UTC by Julien Isorce
Modified: 2016-11-04 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video: add gst_video_decoder_allocate_output_frame_full (3.48 KB, patch)
2016-10-18 15:57 UTC, Julien Isorce 		none Details | Review
video: add gst_video_decoder_allocate_output_frame_with_params (3.55 KB, patch)
2016-11-03 20:59 UTC, Julien Isorce 		committed Details | Review

Description Julien Isorce 2016-10-18 15:54:02 UTC 
It add a 3th argument GstBufferPoolAcquireParams to pass to gst_buffer_pool_acquire_buffer.
    
If a user subclass GstBufferPoolAcquireParams, this allow to pass an updated param to the underlying buffer pool at each gst_video_decoder_allocate_output_frame_full call.

I need that in gstvaapidecode to pass the current "surface" (not exaclty but to simplify) to the pool, when it calls "gst_video_decoder_allocate_output_frame(_full)"

Patch will follow.
Comment 1 Julien Isorce 2016-10-18 15:57:43 UTC 
Created attachment 337948 [details] [review]
video: add gst_video_decoder_allocate_output_frame_full
Comment 2 Víctor Manuel Jáquez Leal 2016-10-18 16:44:24 UTC 
Review of attachment 337948 [details] [review]:

it makes sense to me

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3966,3 @@
+ */
+GstFlowReturn
+gst_video_decoder_allocate_output_frame_full (GstVideoDecoder *

Naming new API makes me nervous. What about gst_video_decoder_allocate_output_frame_with_params()?
Comment 3 Julien Isorce 2016-10-19 15:40:24 UTC 
In reply to Víctor Manuel Jáquez Leal from comment #2)
> +gst_video_decoder_allocate_output_frame_full (GstVideoDecoder *
> 
> What about gst_video_decoder_allocate_output_frame_with_params()?

Good idea, will update the patch. Thx.
Comment 4 Sebastian Dröge (slomo) 2016-10-20 11:36:49 UTC 
Comment on attachment 337948 [details] [review]
video: add gst_video_decoder_allocate_output_frame_full

Generally makes sense to me too. It's "Since: 1.12" though, we only put stable versions there
Comment 5 Julien Isorce 2016-11-03 20:59:18 UTC 
Created attachment 339077 [details] [review]
video: add gst_video_decoder_allocate_output_frame_with_params

rename and fix version
Comment 6 Sebastian Dröge (slomo) 2016-11-04 15:09:34 UTC 
Go ahead :)
Comment 7 Julien Isorce 2016-11-04 16:23:12 UTC 
commit 3bf893e12aa1161944f4fb1a1da7a1e14af92fdb
Author: Julien Isorce <j.isorce@samsung.com>
Date:   Fri Oct 14 15:14:14 2016 +0100

    video: add gst_video_decoder_allocate_output_frame_with_params
    
    It adds a third argument to pass GstBufferPoolAcquireParams
    to gst_buffer_pool_acquire_buffer.
    
    If a user subclasses GstBufferPoolAcquireParams, this allows to
    pass an updated param to the underlying buffer pool at each
    gst_video_decoder_allocate_output_frame_with_params call.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=773165