After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773115 - MetaOnscreenNative: fix mirror mode with stage views
MetaOnscreenNative: fix mirror mode with stage views
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 773225 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-10-17 17:05 UTC by Rui Matos
Modified: 2016-10-19 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaOnscreenNative: fix mirror mode with stage views (2.99 KB, patch)
2016-10-17 17:05 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-10-17 17:05:27 UTC 
see patch
Comment 1 Rui Matos 2016-10-17 17:05:31 UTC 
Created attachment 337876 [details] [review]
MetaOnscreenNative: fix mirror mode with stage views

Using the view's MetaMonitorInfo to find all the crtcs which should be
configured to display a given onscreen doesn't work unfortunately. The
association runs only the other way around, i.e. we need to go through
each crtc and find the ones corresponding to our monitor info.
Comment 2 Jonas Ådahl 2016-10-18 01:34:43 UTC 
Review of attachment 337876 [details] [review]:

Oh, I see. A bit awkward I guess. Any reason why we can't add the mirrored MetaOutput's to their corresponding "logical_monitor"?
Comment 3 Rui Matos 2016-10-18 12:28:47 UTC 
(In reply to Jonas Ådahl from comment #2)
> Oh, I see. A bit awkward I guess. Any reason why we can't add the mirrored
> MetaOutput's to their corresponding "logical_monitor"?

I guess we could, it's just the way this code was structured. I think
the rationale is that the number of objects (crtcs in this case) is
always small enough that iterating through all of them isn't a big
deal, although the same argument could be used to add a list of crtcs
to MetaMonitorInfo in this case.

Attachment 337876 [details] pushed as 1d4a5a7 - MetaOnscreenNative: fix mirror mode with stage views
Comment 4 Florian Müllner 2016-10-19 14:27:56 UTC 
*** Bug 773225 has been marked as a duplicate of this bug. ***