GNOME Bugzilla – Bug 773106
audiodecoder: Degrade warnings
Last modified: 2018-11-03 11:50:58 UTC
When doing DTX generation in decoders, they are indeed producing buffers without having a corresponding input buffer, so this code needs to be revisited, and perhaps need a special method for pushing buffers like this?
Created attachment 337857 [details] [review] audiodecoder: Degrade warnings
Comment on attachment 337857 [details] [review] audiodecoder: Degrade warnings Yes we need something better here. The problem with your approach is that it will break the timestamp tracking inside GstAudioDecoder if there are more frames pushed (especially in the middle) as there were input.
Sounds like we should retitle this to something else? We need new API for this? The patch looks harmless to commit in any case, doesn't it?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/302.