After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773106 - audiodecoder: Degrade warnings
audiodecoder: Degrade warnings
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-17 14:01 UTC by Stian Selnes (stianse)
Modified: 2018-11-03 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audiodecoder: Degrade warnings (1.63 KB, patch)
2016-10-17 14:01 UTC, Stian Selnes (stianse)
needs-work Details | Review

Description Stian Selnes (stianse) 2016-10-17 14:01:26 UTC
When doing DTX generation in decoders, they are indeed
producing buffers without having a corresponding input
buffer, so this code needs to be revisited, and perhaps
need a special method for pushing buffers like this?
Comment 1 Stian Selnes (stianse) 2016-10-17 14:01:30 UTC
Created attachment 337857 [details] [review]
audiodecoder: Degrade warnings
Comment 2 Sebastian Dröge (slomo) 2016-10-20 11:08:33 UTC
Comment on attachment 337857 [details] [review]
audiodecoder: Degrade warnings

Yes we need something better here. The problem with your approach is that it will break the timestamp tracking inside GstAudioDecoder if there are more frames pushed (especially in the middle) as there were input.
Comment 3 Tim-Philipp Müller 2016-12-23 17:41:40 UTC
Sounds like we should retitle this to something else? We need new API for this?

The patch looks harmless to commit in any case, doesn't it?
Comment 4 GStreamer system administrator 2018-11-03 11:50:58 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/302.