After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773085 - build: Fix git submodule fetching with builddir != srcdir
build: Fix git submodule fetching with builddir != srcdir
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-17 11:54 UTC by Bastien Nocera
Modified: 2016-12-22 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix git submodule fetching with builddir != srcdir (1.03 KB, patch)
2016-10-17 11:54 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-10-17 11:54:45 UTC 
.
Comment 1 Bastien Nocera 2016-10-17 11:54:50 UTC 
Created attachment 337834 [details] [review]
build: Fix git submodule fetching with builddir != srcdir

We were running the git submodule update in builddir, instead of srcdir,
which might have lead to submodules not updating, and submodule tags
being reverted to older versions in some contributions.
Comment 2 Rui Matos 2016-10-21 16:26:21 UTC 
Review of attachment 337834 [details] [review]:

looks good
Comment 3 Bastien Nocera 2016-10-21 16:29:35 UTC 
Attachment 337834 [details] pushed as 56d0d72 - build: Fix git submodule fetching with builddir != srcdir
Comment 4 gnome.vrb 2016-12-22 21:23:59 UTC 
gnome-shell build fails with the above commit. ( pushd / popd are bash specific and the script uses /bin/sh )

*** Configuring gnome-shell *** [1/93]
/home/dev/jhbuild/checkout/gnome-shell/autogen.sh: 14: /home/dev/jhbuild/checkout/gnome-shell/autogen.sh: pushd: not found
+ Setting up submodules
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
/home/dev/jhbuild/checkout/gnome-shell/autogen.sh: 24: /home/dev/jhbuild/checkout/gnome-shell/autogen.sh: popd: not found
/home/dev/jhbuild/install/bin/gnome-autogen.sh
Comment 5 gnome.vrb 2016-12-22 21:39:13 UTC 
Opened new bug 776412