After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773077 - _gdk_wayland_display_get_cursor_for_name / _with_scale does not return NULL for an unknown icon
_gdk_wayland_display_get_cursor_for_name / _with_scale does not return NULL f...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 772966 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-10-17 10:36 UTC by Trever Adams
Modified: 2017-05-12 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem (566 bytes, patch)
2016-10-17 10:36 UTC, Trever Adams 		committed Details | Review

Description Trever Adams 2016-10-17 10:36:05 UTC 
Created attachment 337824 [details] [review]
Patch to fix the problem

aisleriot and others that support many different platforms expect these functions to return NULL if an icon is not found. Without the attached patch, a useless structure is returned and the icon disappears. With this patch, things function as they should.

This was originally reported in https://bugzilla.redhat.com/show_bug.cgi?id=1352244 which contains other patches for aisleriot which may be useful.

I am not sure how far this goes back, but it exists in the current version and has existed for at least 8 months.

Thank you for looking into this.
Comment 1 Trever Adams 2016-10-17 10:37:00 UTC 
The fix is based on comparison with the x11 version.
Comment 2 Matthias Clasen 2016-10-17 12:51:56 UTC 
Review of attachment 337824 [details] [review]:

thanks, that looks just like what I came up with here
Comment 3 Trever Adams 2016-10-17 14:55:22 UTC 
Thank you!
Comment 4 Trever Adams 2016-10-17 19:19:58 UTC 
I do not have write access to the git tree. What shall I do to get it committed?
Comment 5 Matthias Clasen 2016-10-17 19:21:28 UTC 
I'll pick it up, no worries. The a-c-n status is more a reminder for myself
Comment 6 Trever Adams 2016-10-17 19:23:22 UTC 
Alright. Thank you Matthias!
Comment 7 Matthias Clasen 2016-10-17 19:55:29 UTC 
ended up pushing my own version of the fix that had some other changes. Thanks
Comment 8 Trever Adams 2016-10-17 20:02:54 UTC 
Ok. Thank you for the heads up.
Comment 9 Christian Persch 2016-10-17 20:14:31 UTC 
*** Bug 772966 has been marked as a duplicate of this bug. ***
Comment 10 Trever Adams 2016-11-28 02:59:11 UTC 
The fix has not shown up in subsequent 3.22.x releases. Is it possible to get this included in the next one? Or if it is a 3.23.x release, there?
Comment 11 Matthias Clasen 2016-11-28 20:07:41 UTC 
pushed it now
Comment 12 Trever Adams 2016-12-02 20:55:49 UTC 
Thank you.