After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773063 - Support gcc6 -Werror=format-security (1.6.0)
Support gcc6 -Werror=format-security (1.6.0)
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.6.x
Other Linux
: Normal normal
: 1.6
Assigned To: GNOME Commander maintainer(s)
GNOME Commander maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-17 04:07 UTC by Mamoru TASAKA
Modified: 2016-10-18 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to compile with -Werror=format-security (374 bytes, patch)
2016-10-17 04:07 UTC, Mamoru TASAKA 		none Details | Review

Description Mamoru TASAKA 2016-10-17 04:07:26 UTC 
Created attachment 337809 [details] [review]
Patch to compile with -Werror=format-security

Fedora 24 and above uses gcc 6.2.1 with -Werror=format-security and gcmd 1.6.0 does not compile with this option:

gnome-commander-1.6.0/_builddir/../src/gnome-cmd-gkeyfile-utils.cc:109:35: error: format not a string literal and no format arguments [-Werror=format-security]
     written = fprintf(fd, contents);

The attached patch (this is for 1.6.0) should fix this issue.
Comment 1 Uwe Scholz 2016-10-18 16:09:15 UTC 
Thank you for the report and the attached bugfix. The fix will go into the next bugfix release of gcmd, v1.6.1.