After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773049 - Pressing enter doesn't always start next level
Pressing enter doesn't always start next level
Status: RESOLVED FIXED
Product: gnome-nibbles
Classification: Applications
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-nibbles-maint
gnome-nibbles-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-16 16:39 UTC by FelixO
Modified: 2016-10-24 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make 'Next Level' button the default widget (2.05 KB, patch)
2016-10-24 14:03 UTC, Iulian Radu
committed Details | Review
Make 'Next Level' button the default widget (2.05 KB, patch)
2016-10-24 14:04 UTC, Iulian Radu
committed Details | Review

Description FelixO 2016-10-16 16:39:21 UTC
Correct behaviour:

1. Complete level. "Level n completed!" is displayed
2. Press Enter or Return and next level begins

But:

1. Complete level. "Level n completed!" is displayed
2. Press Up arrow (or any other key)
2. Now pressing Enter or Return has no effect and you have to use the mouse to start the next level
Comment 1 Iulian Radu 2016-10-24 14:03:30 UTC
Created attachment 338346 [details] [review]
Make 'Next Level' button the default widget

Currently, when a level is completed, the focus is set on the Next
Level button so by pressing Enter the user can immediately start the
next level. This can sometimes lead to problems if the focus is changed.

Instead of relying on the widget's focus, make the 'Next Level' button
the default widget so by pressing enter with no focus, the next level
is always started.
Comment 2 Iulian Radu 2016-10-24 14:04:47 UTC
The following fix has been pushed:
628ffde Make 'Next Level' button the default widget
Comment 3 Iulian Radu 2016-10-24 14:04:51 UTC
Created attachment 338347 [details] [review]
Make 'Next Level' button the default widget

Currently, when a level is completed, the focus is set on the Next
Level button so by pressing Enter the user can immediately start the
next level. This can sometimes lead to problems if the focus is changed.

Instead of relying on the widget's focus, make the 'Next Level' button
the default widget so by pressing enter with no focus, the next level
is always started.