GNOME Bugzilla – Bug 773002
netsim: more features and love
Last modified: 2018-01-27 10:21:53 UTC
Created attachment 337768 [details] [review] token bucket algorithm A collection of patches that updates netsim with different types of delay distribution as well as a token bucket algorithm for simulating network congestion and general cleanups. Maybe it could be destined for greater things (-good) in the not too distant future?
Created attachment 337769 [details] [review] add normal distribution and delay-distribution property
Created attachment 337770 [details] [review] max-delay inclusive
Created attachment 337771 [details] add gamme
Created attachment 337772 [details] [review] add gamma distribution
Review of attachment 337768 [details] [review]: Did you think of adding a "simulated" IP/UDP header to each packet. I guess for video it won't matter much, but for audio it probably would. ::: gst/netsim/gstnetsim.c @@ -74,3 +82,2 @@ #define GST_NET_SIM_GET_PRIVATE(o) \ - (G_TYPE_INSTANCE_GET_PRIVATE ((o), GST_TYPE_NET_SIM, \ - GstNetSimPrivate)) + (G_TYPE_INSTANCE_GET_PRIVATE ((o), GST_TYPE_NET_SIM, GstNetSimPrivate)) Did you run it through the gst-indent script? @@ +100,3 @@ gst_net_sim_loop (GstNetSim * netsim) { + GstNetSimPrivate *priv = netsim->priv; Any chance you can separate the stylistic changes?
Created attachment 339713 [details] [review] update patch without stylistic changes
Created attachment 339714 [details] [review] stylistic changes and gst-indent in separate patch apply this patch first!
These features are in git already, I picked them from your github trees, so I think we can close this.