After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772978 - CSS for popover menus is hardcoded; overwrites global theme
CSS for popover menus is hardcoded; overwrites global theme
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-15 12:02 UTC by Wolfgang Ulbrich
Modified: 2016-10-18 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
uggly popover menu background (368.45 KB, image/png)
2016-10-15 12:02 UTC, Wolfgang Ulbrich
Details

Description Wolfgang Ulbrich 2016-10-15 12:02:26 UTC
Created attachment 337754 [details]
uggly popover menu background

Those setting in dconf-editor.css overrides gtk themes settings and popover menus are looking bad.

/* egtk */
window > popover.menu {
  background:inherit;
}

There are themes which using another bg color for menus as the general window bg color.
See the attachment how it looks with a theme which use dark menus.
Every setting in your css overrides any gtk theme, so i can't do anything in the theme itself.
Theme is Blue-Submarine from MATE desktop.
Note, it looks weird with light themes too if they use another color for menus.
Comment 1 Arnaud B. 2016-10-18 06:33:20 UTC
I thought I was doing something weird in the app’ (I sometimes do), causing problems with a specific theme (egtk), but looks like it’s the said theme that is broken here. I just removed the problematic hack, both on 3.22 (next release 3.22.2, not sure when) and in master (future 3.24, to be released in five months).

> Every setting in your css overrides any gtk theme, so i can't do anything
> in the theme itself.

You should certainly be able to override such things by using a selector with a bigger specificity, but you’ve done the right thing by just reporting the bug. Thanks !
Comment 2 Wolfgang Ulbrich 2016-10-18 08:31:47 UTC
Thanks for fixing that.

(In reply to Arnaud B. from comment #1)
> I thought I was doing something weird in the app’ (I sometimes do), causing
> problems with a specific theme (egtk), but looks like it’s the said theme
> that is broken here. I just removed the problematic hack, both on 3.22 (next
> release 3.22.2, not sure when) and in master (future 3.24, to be released in
> five months).
Hmm, the fixes for buttons in pathbar are real urgent. Otherwise you can't see the path of a gsettings key after the good old sidebar is removed.
Currently dconf-editor is unusable in fedora 25 beta if a theme use another bg color for the headerbar, see my screenshot.
> 
> > Every setting in your css overrides any gtk theme, so i can't do anything
> > in the theme itself.
> 
> You should certainly be able to override such things by using a selector
> with a bigger specificity, but you’ve done the right thing by just reporting
> the bug. Thanks !
Before i filed out the report i tried to use those settings, which are working with debugging dconf-editor with gtk3-inspector, but not in the theme css itself.


window.background.dconf-editor popover.menu {
    background-color: @bg_dark_color;
    background: @bg_dark_color;
}

.dconf-editor headerbar.titlebar .pathbar,
.dconf-editor headerbar.titlebar .pathbar button label.item {
    color: @menu_fg_dark_color;
}


.dconf-editor headerbar.titlebar .pathbar button:hover label.item,
.dconf-editor headerbar.titlebar .pathbar button:disabled label.item {
    color: shade (@theme_selected_bg_color, 1.6);
}

Only '.dconf-editor headerbar.titlebar .pathbar' works which styles the slash in the pathbar.
The other stuff is set up in your css and i couldn't override them.
Same if i use 'window.background.dconf-editor' as root selector everywhere.
Comment 3 Arnaud B. 2016-10-18 12:32:10 UTC
> Hmm, the fixes for buttons in pathbar are real urgent. Otherwise you can't
> see the path of a gsettings key after the good old sidebar is removed.
> Currently dconf-editor is unusable in fedora 25 beta if a theme use another
> bg color for the headerbar, see my screenshot.

That was bug 771831 and it has been fixed hopefully in 3.22.1, already available in my Fedora 25 (I probably activated testing updates or something like that at one point). If there’re more problems, please reopen.

>> You should certainly be able to override such things by using a selector
>> with a bigger specificity, but you’ve done the right thing by just reporting
>> the bug. Thanks !
> […]
> The other stuff is set up in your css and i couldn't override them.
> Same if i use 'window.background.dconf-editor' as root selector everywhere.

Strange. Good to know. Thanks for the tests & informations.