GNOME Bugzilla – Bug 772940
Fix updates monitor use
Last modified: 2016-10-14 16:09:01 UTC
The updates monitor is being initialized/killed depending on the value of the download-updates setting but the use of this setting should be the responsibility of the updates monitor and it should always be initialized. The monitor also prevents the automatic checking when on a metered connection but this may not be desirable for all users so there should be a way to configure this.
Created attachment 337726 [details] [review] Always initialize the updates monitor The updates monitor was being initialized and destroyed depending on the download-updates setting. This setting however should not be enough to dictate what the updates monitor does as some plugins can implement a refresh that will fetch info about the updates without having to download them.
Created attachment 337727 [details] [review] Use a gsetting for auto-refreshing on metered connections GNOME Software was simply preventing any checks for updates when on a metered connection but some users may have that kind of connection as their only one and wish to perform those checks.
Created attachment 337728 [details] [review] Change how the payload flag is used in the updates monitor This patch makes the updates monitor use the payload flag only if the download-updates setting is true. Otherwise it just uses the metadata flag.
Created attachment 337729 [details] [review] Use a gsetting for auto-refreshing on metered connections GNOME Software was simply preventing any checks for updates when on a metered connection but some users may have that kind of connection as their only one and wish to perform those checks.
Pushed to master after Richard's +1.