GNOME Bugzilla – Bug 772924
[PATCH] Don't install Xorg session file twice
Last modified: 2016-10-14 20:13:16 UTC
Created attachment 337696 [details] [review]
Don't install Xorg session file twice
Currently the GNOME Xorg session has two equal session files:
I think the latter file is pointless, and causes problems and duplicated entries in some display managers (e.g. in LightDM), because its name is the same as the Wayland session file. It would be a much cleaner to have:
- "GNOME" session only in wayland-sessions.
- "GNOME on Xorg" session in xsessions.
fallback is implemented by having the same session available in /usr/share/wayland-sessions and /usr/share/xsessions
(In reply to Ray Strode [halfline] from comment #1)
> fallback is implemented by having the same session available in
> /usr/share/wayland-sessions and /usr/share/xsessions
But it's implemented only in GDM. Other display managers may confused by having two sessions with the same name.
And if Wayland is disabled or unsupported, then the two xsessions (gnome-xorg, gnome) are identical, both launch the same GNOME on Xorg session. I see no reason to keep both of them.
sure, but gnome doesn't work well with other display managers anyway. I mean lock screen relies on GDM.
The reason to keep gnome.desktop is it's used as a wayland fallback if wayland fails. The reason to keep gnoem-xorg is so people can explicitly choose Xorg even if wayland wouldn't have fallen back. Eventually gnome-xorg will get dropped but not for a while.
(In reply to Ray Strode [halfline] from comment #3)
> The reason to keep gnome.desktop is it's used as a wayland fallback if
> wayland fails. The reason to keep gnoem-xorg is so people can explicitly
> choose Xorg even if wayland wouldn't have fallen back. Eventually
> gnome-xorg will get dropped but not for a while.
I think it would better to hard-code the whole fallback think in GDM, e.g. if gnome wayland-session fails, then start the gnome-xorg xsession.
That's a possibility, but it has a few problems (What should get written to accountsservice ? gnome ? gnome-xorg ? what if the user uninstalls the proprietary nvidia driver, what should get used then ? What if another desktop (say kde or enlightenment) want to fall back too ? Do I need to hardcode their options?)
Honestly, since lightdm doesn't support wayland sessions anyway, probably the best bet would be for the distribution to package the gnome-xorg session inside a wayland-support subpackage, and make lightdm conflict with that subpackage.
LightDM supports Wayland sessions, but unable to handle multiple sessions with the same name. I reported this problem on LightDM bug tracker: