After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772867 - [Regression][Bisected] Nautilus crashes when mounting encrypted volume
[Regression][Bisected] Nautilus crashes when mounting encrypted volume
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: udisks2 volume monitor
git master
Other Linux
: Normal major
: ---
Assigned To: gvfs-maint
gvfs-maint
: 772942 772961 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-10-13 14:30 UTC by gedgon
Modified: 2016-10-17 06:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description gedgon 2016-10-13 14:30:11 UTC
b77369832fd6fb97e1f036998663f2488ff15022 is the first bad commit
commit b77369832fd6fb97e1f036998663f2488ff15022
Author: Ondrej Holy <oholy@redhat.com>
Date:   Mon Sep 26 15:12:47 2016 +0200

    udisks2: Use device path to match mount points also
    
    Mount path is used to match mount points currently, however device
    path should be used also in order to be sure it is really corresponding
    mount point. Same mount path can be used for multiple mount entries
    (it is also used e.g. for autofs).
    
    $ mount | grep /media/test
    systemd-1 on /media/test type autofs ...
    localhost:/home/oholy on /media/test type nfs4 ...
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771740



Screencast (1.94MB): https://www.dropbox.com/s/4f14t4rahvzheo2/gvfs.webm?dl=0




Coredump (redacted machine ID):

coredumpctl info 24289
           PID: 24289 (nautilus)
           UID: 1003 (test)
           GID: 1003 (test)
        Signal: 5 (TRAP)
     Timestamp: czw 2016-10-13 16:17:08 CEST (8min ago)
  Command Line: /usr/bin/nautilus --gapplication-service
    Executable: /usr/bin/nautilus
 Control Group: /user.slice/user-1003.slice/user@1003.service/dbus.service
          Unit: user@1003.service
     User Unit: user@1003.service
         Slice: user-1003.slice
     Owner UID: 1003 (test)
       Boot ID: 
    Machine ID: 
      Hostname: localhost
      Coredump: /var/lib/systemd/coredump/core.nautilus.1003
       Message: Process 24289 (nautilus) of user 1003 dumped core.
                
                Stack trace of thread 24289:
                #0  0x00007f381d6dcff1 n/a (libglib-2.0.so.0)
                #1  0x00007f381d6df731 g_log_writer_default (libglib-2.0.so.0)
                #2  0x00007f381d6ddb8c g_log_structured_array (libglib-2.0.so.0)
                #3  0x00007f381d6dde89 g_log_structured (libglib-2.0.so.0)
                #4  0x00007f381edfd410 n/a (libgdk-3.so.0)
                #5  0x00007f381d6d7179 g_main_context_check (libglib-2.0.so.0)
                #6  0x00007f381d6d7724 n/a (libglib-2.0.so.0)
                #7  0x00007f381d6d789c g_main_context_iteration (libglib-2.0.so.0)
                #8  0x00007f381dc9154d g_application_run (libgio-2.0.so.0)
                #9  0x00000000004291aa n/a (nautilus)
                #10 0x00007f381cdee291 __libc_start_main (libc.so.6)
                #11 0x000000000042920a n/a (nautilus)
                
                Stack trace of thread 24290:
                #0  0x00007f381cead48d poll (libc.so.6)
                #1  0x00007f381d6d7786 n/a (libglib-2.0.so.0)
                #2  0x00007f381d6d789c g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f381d6d78e1 n/a (libglib-2.0.so.0)
                #4  0x00007f381d6ff0d5 n/a (libglib-2.0.so.0)
                #5  0x00007f381d173454 start_thread (libpthread.so.0)
                #6  0x00007f381ceb67df __clone (libc.so.6)
                
                Stack trace of thread 24294:
                #0  0x00007f381cead48d poll (libc.so.6)
                #1  0x00007f381d6d7786 n/a (libglib-2.0.so.0)
                #2  0x00007f381d6d789c g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f380e49f4bd n/a (libdconfsettings.so)
                #4  0x00007f381d6ff0d5 n/a (libglib-2.0.so.0)
                #5  0x00007f381d173454 start_thread (libpthread.so.0)
                #6  0x00007f381ceb67df __clone (libc.so.6)
                
                Stack trace of thread 24291:
                #0  0x00007f381cead48d poll (libc.so.6)
                #1  0x00007f381d6d7786 n/a (libglib-2.0.so.0)
                #2  0x00007f381d6d7b12 g_main_loop_run (libglib-2.0.so.0)
                #3  0x00007f381dcbd316 n/a (libgio-2.0.so.0)
                #4  0x00007f381d6ff0d5 n/a (libglib-2.0.so.0)
                #5  0x00007f381d173454 start_thread (libpthread.so.0)
                #6  0x00007f381ceb67df __clone (libc.so.6)
                
                Stack trace of thread 24400:
Comment 1 Ondrej Holy 2016-10-14 07:37:56 UTC
Thanks for your bug report. However, I can't reproduce on Fedora 25 with GVfs 1.30.1. Can you please provide more info about it? What nautilus version do you have? What is partition layout and filesystems on that device? Does mounting of encrypted devices work properly with gvfs-mount? What is output from "gvfs-mount -li" before and after mount?
Comment 2 gedgon 2016-10-14 12:03:55 UTC
Sorry. It's an up to date Arch Linux with GNOME 3.22.(1)/Nautilus 3.22.0. The drive is encrypted with a whole device luks/dm-crypt and it's a single Ext4 partition on it.


gvfs-mount -li (before mounting /dev/sdb)

Drive(1): ST9500420AS
  Type: GProxyDrive (GProxyVolumeMonitorUDisks2)
  ids:
   unix-device: '/dev/sdb'
  themed icons:  [drive-harddisk]  [drive]
  symbolic themed icons:  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk]  [drive]
  is_removable=0
  is_media_removable=0
  has_media=1
  is_media_check_automatic=1
  can_poll_for_media=0
  can_eject=0
  can_start=0
  can_stop=0
  start_stop_type=shutdown
  sort_key=00coldplug/00fixed/sd____b
  Volume(0): 500 GB Encrypted
    Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
    ids:
     class: 'device'
     unix-device: '/dev/sdb'
     uuid: '915497a2-25c0-4f03-a233-31360d6668cb'
    symbolic themed icons:  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk]  [drive]
    can_mount=1
    can_eject=0
    should_automount=0
    sort_key=gvfs.time_detected_usec.1476444935100748



gvfs-mount -li (after mounting /dev/sdb)

Drive(1): ST9500420AS
  Type: GProxyDrive (GProxyVolumeMonitorUDisks2)
  ids:
   unix-device: '/dev/sdb'
  themed icons:  [drive-harddisk]  [drive]
  symbolic themed icons:  [drive-harddisk-symbolic]  [drive-symbolic]  [drive-harddisk]  [drive]
  is_removable=0
  is_media_removable=0
  has_media=1
  is_media_check_automatic=1
  can_poll_for_media=0
  can_eject=0
  can_start=0
  can_stop=0
  start_stop_type=shutdown
  sort_key=00coldplug/00fixed/sd____b
Volume(1): Storage-3 [500GB]
  Type: GProxyVolume (GProxyVolumeMonitorUDisks2)
  ids:
   class: 'device'
  themed icons:  [drive-removable-media]  [drive-removable]  [drive]
  symbolic themed icons:  [drive-removable-media-symbolic]  [drive-removable-symbolic]  [drive-symbolic]  [drive-removable-media]  [drive-removable]  [drive]
  can_mount=1
  can_eject=0
  should_automount=0
  sort_key=gvfs.time_detected_usec.1476445127054876




gvfs-mount -d /dev/sdb

(gvfs-mount:3261): GLib-GIO-CRITICAL **: g_mount_get_root: assertion 'G_IS_MOUNT (mount)' failed

(gvfs-mount:3261): GLib-GIO-CRITICAL **: g_file_get_path: assertion 'G_IS_FILE (file)' failed
Mounted /dev/dm-1 at (null)

(gvfs-mount:3261): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

(gvfs-mount:3261): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed



However, in both cases (using Nautilus and gvfs-mount) the volume is unlocked and partition mounted in a correct mount point.
Comment 3 Ondrej Holy 2016-10-14 13:35:19 UTC
Thanks for the info. I guess what's wrong there probably. Do you have some custom fstab/crypttab entries? Can you provide it?
Comment 4 gedgon 2016-10-14 13:39:41 UTC
Only in fstab, and it was generated by gnome-disks, IIRC
/dev/disk/by-uuid/5c8fe9e4-6659-41dd-b2aa-5795797e740f /mnt/Storage-3 auto nosuid,nodev,nofail,x-gvfs-show,noauto,x-gvfs-name=Storage-3%20%5B500GB%5D 0 0
Comment 5 Ondrej Holy 2016-10-17 06:41:08 UTC
Thanks for your bug report! I've already reverted the patches causing those issues and made an another release. I am sorry for the inconvenience...
Comment 6 Ondrej Holy 2016-10-17 06:41:11 UTC
*** Bug 772961 has been marked as a duplicate of this bug. ***
Comment 7 Ondrej Holy 2016-10-17 06:41:13 UTC
*** Bug 772942 has been marked as a duplicate of this bug. ***