After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772837 - ggit_repository_discover() not resolving inside of flatpak
ggit_repository_discover() not resolving inside of flatpak
Status: RESOLVED FIXED
Product: libgit2-glib
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-13 05:47 UTC by Christian Hergert
Modified: 2019-02-22 03:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Hergert 2016-10-13 05:47:58 UTC
I'm not sure what is causing this, but I noticed in Builder that it wasn't loading the git backend inside the flatpak app. It might be something like needing to set the 'traverse filesystems' bit for git_repository_discover().

I ended up adding workaround for Builder to do manual discovery, but if we figure out why this is happening, I can drop that code.
Comment 1 jessevdk@gmail.com 2016-11-05 12:41:06 UTC
Sounds like a flatpak issue then.
Comment 2 Christian Hergert 2016-11-06 07:20:37 UTC
I don't think this is a flatpak issue. It is perfectly reasonable to have multiple filesystems mounted in a mount namespace. (sshfs for example). But libgit2-glib does not expose the flags parameter that git_repository_discover() hsa in libgit2 (which we need here).

We could add a ggit_repository_discover_full() or something that wraps/exposes the libgit2 flags.
Comment 3 jessevdk@gmail.com 2016-11-06 09:07:26 UTC
I see, I misunderstood the issue.
Comment 4 jessevdk@gmail.com 2016-11-06 09:53:04 UTC
commit 0a66454cc2fc2333bbe41772e8508e617ac6a91b
Author: Jesse van den Kieboom <jessevdk@gnome.org>
Date:   Sun Nov 6 01:50:44 2016 -0800

    Add ggit_repository_discover_full
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772837