After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772816 - Some strings in the context menu stay in English
Some strings in the context menu stay in English
Status: RESOLVED INCOMPLETE
Product: epiphany
Classification: Core
Component: I18N
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-12 18:58 UTC by Yosef Or Boczko
Modified: 2017-12-11 23:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Translate WebKitContextMenuItem labels (874 bytes, patch)
2016-10-12 21:33 UTC, Michael Catanzaro
committed Details | Review

Description Yosef Or Boczko 2016-10-12 18:58:49 UTC
The strings „Undo”, „Redo”, „Save Page As…” and another strings
in the context menu not translated to Hebrew (but epiphany stand on 100% transated to Hebrew).

The other strings across epiphany appear in Hebrew.
Comment 1 Michael Catanzaro 2016-10-12 21:33:46 UTC
The following fix has been pushed:
c67d4c3 window: Translate WebKitContextMenuItem labels

Unfortunately, while this patch fixes most of the context menu item, some of them still appear in English. I have no clue why, though; I don't see anything else wrong. It's going to need to be investigated by i18n people I'm afraid.

It's worth pointing out that WebKit's Hebrew translation hasn't been updated in nearly two years, but the missing strings here are actually all coming from Epiphany.
Comment 2 Michael Catanzaro 2016-10-12 21:33:49 UTC
Created attachment 337541 [details] [review]
window: Translate WebKitContextMenuItem labels

This broke in the GAction port
Comment 3 Michael Catanzaro 2016-10-12 21:48:52 UTC
The missing strings are definitely going through both N_() and _(), following the same codepath as the strings that are working, so this might need debugging from a gettext expert. :(
Comment 4 Yosef Or Boczko 2016-10-12 22:08:45 UTC
> It's worth pointing out that WebKit's Hebrew translation hasn't been updated
> in nearly two years, but the missing strings here are actually all coming
> from Epiphany.

I updated the WebKit's Hebrew translation a few month ago iirc.
Comment 5 Michael Catanzaro 2016-10-12 23:14:46 UTC
(In reply to Yosef Or Boczko from comment #4)
> I updated the WebKit's Hebrew translation a few month ago iirc.

I checked WebKit trunk. The header says:

"POT-Creation-Date: 2015-01-20 12:06+0000\n"
"PO-Revision-Date: 2015-03-17 13:28+0200\n"
"Last-Translator: Yosef Or Boczko <yoseforb@gnome.org>\n"

Anyway, that's not the problem here, since the untranslated strings are coming from Epiphany and not WebKit.
Comment 6 Michael Catanzaro 2016-10-12 23:15:32 UTC
(In reply to Michael Catanzaro from comment #5)
> (In reply to Yosef Or Boczko from comment #4)
> > I updated the WebKit's Hebrew translation a few month ago iirc.
> 
> I checked WebKit trunk. The header says:
> 
> "POT-Creation-Date: 2015-01-20 12:06+0000\n"
> "PO-Revision-Date: 2015-03-17 13:28+0200\n"
> "Last-Translator: Yosef Or Boczko <yoseforb@gnome.org>\n"

(If you have a newer translation, please do file a bug on bugzilla.webkit.org, and select the WebKitGtk component so that we notice.)
Comment 7 Michael Catanzaro 2016-10-22 02:36:55 UTC
OK, moving this one to NEEDINFO because I've investigated and don't know what's wrong with the remaining strings. Someone else will have to get to the root of the problem.
Comment 8 André Klapper 2017-11-21 14:54:58 UTC
Yosef: Is this still an issue in 3.26?
Comment 9 Michael Catanzaro 2017-12-11 23:25:04 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!