GNOME Bugzilla – Bug 772796
Missing gtk menu border when composing/shadow is disabled
Last modified: 2018-01-24 14:56:39 UTC
Missing Gtk menu borders when composing/shadow is disabled. Here is screenshot: http://i.imgur.com/PZPIyD6.png
(In reply to Branko from comment #0) > Missing Gtk menu borders when composing/shadow is disabled. Here is > screenshot: > > http://i.imgur.com/PZPIyD6.png You are using XFCE?
(In reply to Maxim from comment #1) > (In reply to Branko from comment #0) > > Missing Gtk menu borders when composing/shadow is disabled. Here is > > screenshot: > > > > http://i.imgur.com/PZPIyD6.png > > You are using XFCE? Yes.
Created attachment 350968 [details] [review] Add border back to menus Add border back to menus I have fixed it here with this change. Duplicate bug: https://bugzilla.gnome.org/show_bug.cgi?id=763798
Hey, sorry for the non-activity on this bug. This bug is caused by the Adwaita engine and I have little knowledge over that. I reached out to cosimoc but either he didn’t notice/have time/forgot or I forgot to remind him (the latter is probably much more to blame :P). Hopefully we’ll fix this by 3.26. Regarding the patch––yes, it can by used as a workaround, but it’s too hacky for me to be confortable merging. Feel free to use it, but I’ll wait for a proper solution.
Hey Juraj, thanks for your feedback! As I found out, since 3.20 the style definitions have been completely refactored and reorganized, and it seems that something just have been forgotten within this process. Until 3.18 GTKMenu have been styled by "menu" and "menu_framed_box". The latter contained this "engine "adwaita" { }". See: https://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-2.0/gtkrc?h=gnome-3-18#n739 But after that, since 3.20, it is just not there anymore, "menu_framed_box" is gone, there is just "menu" left. See: https://git.gnome.org/browse/gnome-themes-standard/tree/themes/Adwaita/gtk-2.0/main.rc?h=gnome-3-20#n1520 Is there a reason, we are not using "engine "adwaita" { }" here anymore? I am just curious and a bit confused, sorry :)
(In reply to Benjamin Bukowski from comment #5) > As I found out, since 3.20 the style definitions have been completely > refactored and reorganized, and it seems that something just have been > forgotten within this process. I’m the one to blame for that, but I’m pretty sure I tested it under a non-composited environment and I remember it working. Dunno, maybe something leftover added the shadow but the memories are quite faint. > … > > Is there a reason, we are not using "engine "adwaita" { }" here anymore? I > am just curious and a bit confused, sorry :) We _are_ using it, it just gets over-drawn by stuff by the looks of it. You can see it before the pixmap engine in the ‘default’ style. Again, for the above reason, I thought that was enough. But I did some testing now and it turns out that it does need to be also in the place you put it in the patch (it also needs to be in the current place, the engine does several things). But, as you’ve noticed, the border gets covered by a thing drawing the menu padding. Swapping the GtkMenu::vertical-padding with ythickness doesn’t do anything, nor does invoking the engine in anyplace different. So, the problem is probably in the engine not being built with padding in mind, since at the time the menu had none. I guess the only guy who can save us now is Cosimo (the engine author). I’ve pinged him on IRC but he hasn’t replied yet, but it shouldn’t be too long.
Thank you very much for clarification!
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-themes-extra/issues/9.