After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772770 - [GtkShortcutsWindow] Support for single-finger swipe gestures
[GtkShortcutsWindow] Support for single-finger swipe gestures
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.22.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 772341
 
 
Reported: 2016-10-11 17:31 UTC by Felix Riemann
Modified: 2016-10-13 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gestures: provide new artwork (22.64 KB, patch)
2016-10-13 10:10 UTC, Jakub Steiner 		none Details | Review
naive patch (3.03 KB, patch)
2016-10-13 14:43 UTC, Felix Riemann 		none Details | Review
gestures: provide new artwork (25.72 KB, patch)
2016-10-13 15:57 UTC, Jakub Steiner 		none Details | Review

Description Felix Riemann 2016-10-11 17:31:20 UTC 
The GtkShortcutsWindow supports swiping gestures only using two fingers right now.

Applications using single-finger swipes could manually construct a matching GtkShortcutsShortcut. However, since icons are used to visualize the gesture, these should match the style of the other gestures. Thus it's probably a better idea to have GTK provide a premade shortcut.
Comment 1 Jakub Steiner 2016-10-13 10:10:58 UTC 
Created attachment 337568 [details] [review]
gestures: provide new artwork

- illustrations for single finger swiping left and right
Comment 2 Felix Riemann 2016-10-13 14:43:05 UTC 
Created attachment 337613 [details] [review]
naive patch

This patch adds the necessary code to make use of Jakub's artwork.
I wrote "Since 4.0" in the documentation, not sure if this can be backported (API?) to 3.22.

Also, I had to generate PNGs of Jakub's artwork as the build would only integrate those, not the SVGs. I don't know whether this conversion is supposed to happen automatically during build, so I left them out of this patch.
Comment 3 Jakub Steiner 2016-10-13 15:57:37 UTC 
Created attachment 337619 [details] [review]
gestures: provide new artwork

- illustrations for single finger swiping left and right
Comment 4 Jakub Steiner 2016-10-13 15:58:37 UTC 
The new patch includes the missing rendered PNGs