GNOME Bugzilla – Bug 772752
Unity: Conversation viewer header labels not displayed dimmed
Last modified: 2018-02-13 23:32:45 UTC
The GTK widget conversion branch has landed in master, which has changed how we present email headers. I'll attach screenshots from before and after the change. Before, field names such as "To" and "Cc" were in light gray. This was nice for readability, since these names are less important than the values that follow them. Similarly, when Geary showed both a person's name and the corresponding email address, we grayed out the email address so that the eye was drawn to the personal name, which is more human-readable. With the change, all text in the headers appears in the same font weight. I think this is a regression, and that we should gray out text selectively as we did before.
Created attachment 337424 [details] before
Created attachment 337425 [details] after
Is this still the case after commit dfe9e3d? The fields and addresses do appear light grey under Adwaita, and the addresses were fixed in Arc after that commit.
I'm running Geary on Ubuntu 16.10 and have built from the latest master. Fields and addresses still appear as in the 'after' screenshot I attached, i.e. black, not gray.
Bumping to 0.12.1 since 0.12.0 isn't likely to make it into Zesty.
Hmm, this looks like an Ambiance bug. In 16.10, The "dim-label" class is only defined in /usr/share/themes/Ambiance/gtk-3.20/gtk-widgets.css, not in gtk-3.0/gtk-widgets.css, despite it being present since 3.14.
Just pushed a workaround to geary-0.12 that adds an Ambiance- and Radiance-specific CSS file and loads it at startup - commit 143ee81b.
I've just reverted that commit, since (after finally working out what broke GNOME Boxes on Aardvark and getting some working VMs again), although GTK+ 3.22 is happy to load both the standard CSS and the extra workaround, GTK+ 3.18 will ignore the first, badly breaking Geary's appearance. But also, after reverting it, the address labels seem to be dim on 16.04 anyway, so I'm not actually sure if this bug still exists - maybe it was fixed in Ambiance in an update?
Adam, can you reproduce this still?
Created attachment 368321 [details] screenshot on Ubuntu 17.10 Here's a screenshot showing the current appearance of Geary (built from master) on Ubuntu 17.10. I'm not sure how the header labels are supposed to look these days, but this looks fine to me.
Yep, that's about right. Cheers!