GNOME Bugzilla – Bug 772741
bin: Add a new GST_BIN_FLAG_STREAMS_AWARE flag
Last modified: 2016-10-31 14:35:12 UTC
See commit
Created attachment 337395 [details] [review] bin: Add a new GST_BIN_FLAG_STREAMS_AWARE flag This flag is to indicate to child elements that they can add and remove pads at any point in time without re-adding existing ones. Elements should post before-hand a GST_MESSAGE_STREAM_COLLECTION
Created attachment 337396 [details] [review] playback: decodebin3 and parsebin are streams-aware Elements within can add/remove pads at anytime without complying with the fallback system.
Review of attachment 337396 [details] [review]: I assumed that the stream_aware flag is for the element what can add/remove pad after the whole pipeline built. If my guess is right, ts demuxer and adaptive demuxer are to be set also? ::: gst/playback/gstdecodebin3.c @@ +604,3 @@ dbin->caps = gst_static_caps_get (&default_raw_caps); + + GST_OBJECT_FLAG_SET (parse_bin, GST_BIN_FLAG_STREAMS_AWARE); It seems to be a typo, "parse_bin" -> "dbin"
(In reply to Wonchul Lee from comment #3) > I assumed that the stream_aware flag is for the element what can add/remove > pad after the whole pipeline built. > If my guess is right, ts demuxer and adaptive demuxer are to be set also? No, it's for the parent bin to indicate to its child elements that they can add/remove pads at anytime (after the collection was posted). tsdemux doesn't contain any elements, nor does adaptivedemux
And now also use it in tsdemux, without all this is a bit useless :)
commit 0ab950f501ef1cb6ee1a786aaf473261ae3fed58 Author: Edward Hervey <edward@centricular.com> Date: Tue Oct 11 12:12:57 2016 +0200 bin: Add a new GST_BIN_FLAG_STREAMS_AWARE flag This flag is to indicate to child elements that they can add and remove pads at any point in time without re-adding existing ones. Elements should post before-hand a GST_MESSAGE_STREAM_COLLECTION https://bugzilla.gnome.org/show_bug.cgi?id=772741 commit acc3a9d242b61dc992a8b8e2acb81f9b7654a414 Author: Edward Hervey <edward@centricular.com> Date: Tue Oct 11 12:36:00 2016 +0200 playback: decodebin3 and parsebin are streams-aware Elements within can add/remove pads at anytime without complying with the fallback system. https://bugzilla.gnome.org/show_bug.cgi?id=772741