After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772733 - Strings from the create project and the autotools-templates not translatable
Strings from the create project and the autotools-templates not translatable
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-11 09:07 UTC by Yosef Or Boczko
Modified: 2016-10-11 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
egg-radio-box: implement translation support (2.29 KB, patch)
2016-10-11 22:06 UTC, Christian Hergert
committed Details | Review
helpers: add ide_gettext() helper (2.56 KB, patch)
2016-10-11 22:24 UTC, Christian Hergert
committed Details | Review
autotools-templates: use Ide.gettext() (1.20 KB, patch)
2016-10-11 22:24 UTC, Christian Hergert
committed Details | Review

Description Yosef Or Boczko 2016-10-11 09:07:06 UTC
The string „No license” from the create projects plugin translated to Hebrew in the he.po file, but remaining in English in the interface.

The same for the strings „Shared Library”, „Empty Project” and „GNOME Application” from the autotools-templates plugin.

Its really strange becaouse another strings in the same files (gbp-create-project-widget.ui for example) appear in Hebrew.
Comment 1 Yosef Or Boczko 2016-10-11 09:09:41 UTC
It right to the tooltip strings too (like „Create a new flatpak-ready GNOME application” etc), they are also translated in the he.po file but remaining in English.
Comment 2 Christian Hergert 2016-10-11 22:06:19 UTC
Created attachment 337477 [details] [review]
egg-radio-box: implement translation support

We were missing translation support when reading data in from
GtkBuilder UI definitions. This uses the translation domain
of the GtkBuilder file to get the translation for the input
text if translatable="yes" in the property definition.
Comment 3 Christian Hergert 2016-10-11 22:24:07 UTC
Created attachment 337478 [details] [review]
helpers: add ide_gettext() helper

This can be used by plugins to reuse our gettext layer from
C rather than duplicating effort for translation domains in
the plugin layer.
Comment 4 Christian Hergert 2016-10-11 22:24:33 UTC
Created attachment 337479 [details] [review]
autotools-templates: use Ide.gettext()

This allows us to use the same translation domain from plugins
as we are using in the C libraries.
Comment 5 Christian Hergert 2016-10-11 22:26:04 UTC
Should be fixed. Please reopen if I happened to miss anything.

Attachment 337477 [details] pushed as 932097e - egg-radio-box: implement translation support
Attachment 337478 [details] pushed as cef340c - helpers: add ide_gettext() helper
Attachment 337479 [details] pushed as b45e3d6 - autotools-templates: use Ide.gettext()