GNOME Bugzilla – Bug 772700
The preferences options appear in the wrong side in RTL
Last modified: 2016-10-11 23:00:13 UTC
Created attachment 337321 [details] Screenshot The preferences options apear in the left side instead of the right side. In the Programming Languages scetion the whole options aprear on the center of the screen. When you choose some language, it move to the right side (its ok) and in the left side you see the specifi-language options, but part of the window has cut off.
Created attachment 337322 [details] Programming Languages - no specific lanuage has been seleceted
Created attachment 337323 [details] Screenshot – Programming Languages – C
This bug right to the Build Preferences too.
Created attachment 337379 [details] [review] column-layout: reverse layout for RTL languages Rather than make the layout more complex when under an RTL language, we can just flip things around right before we size allocate our children. This seems to be the minimal number of strokes to support RTL for this widget.
Thanks! I feel like I'm cheating with the bug fix on this one, but it seems to work! Attachment 337379 [details] pushed as 690f9f0 - column-layout: reverse layout for RTL languages
It still cut off like in the seconf screenshot (when you choose a language in the Programing Languages).
Hrmm, I don't think the problem here is due to RTL but instead due to not having enough screen space for the widgets. The display width is too small to fit the widget and so it is getting dropped. To confirm this, can you unmaximize the window (it will probably become wider than your display) and see if the widgets appear?
Aha, it looks like our min width is about 1348px now, which would certainly present an issue on 1280x* screens.
Created attachment 337481 [details] [review] preferences: save an extra 24px in width Currently we can't use the programming languages side-by-side layout on screens with 1280 width. While that is less than ideal, it could be common today with 2x rendering by the compositor/gtk. So we need to support it to some degree. This gets us down to 1324, so we still need to shave off another 44 pixels from the min-width.
Comment on attachment 337481 [details] [review] preferences: save an extra 24px in width Attachment 337481 [details] pushed as f6c528c - preferences: save an extra 24px in width
Created attachment 337483 [details] [review] preferences: add fallback for small screen sizes If we have a small display (such as 1280xH) then we had the chance we would clip off widgets that should be displayed. Instead, we can simply enable the horizontal scrolling so that the widget can be displayed, albeit with some scrolling.
Comment on attachment 337483 [details] [review] preferences: add fallback for small screen sizes Should at least be able to view the widgets now, even if with a bit of scrolling. Attachment 337483 [details] pushed as 8cce59d - preferences: add fallback for small screen sizes