After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772695 - Show the keyboard shortcuts from left to right even in RTL
Show the keyboard shortcuts from left to right even in RTL
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.22.x
Other Linux
: Normal normal
: Small fix
Assigned To: Christian Hergert
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-10-10 14:07 UTC by Yosef Or Boczko
Modified: 2016-10-10 22:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (69.10 KB, image/png)
2016-10-10 14:07 UTC, Yosef Or Boczko
  Details
always use LTR for shortcut accel (1.11 KB, patch)
2016-10-10 20:54 UTC, Christian Hergert
none Details | Review
set LTR in instance init function of accel label (902 bytes, patch)
2016-10-10 20:58 UTC, Christian Hergert
none Details | Review
Screenshot - with the patch (69.17 KB, image/png)
2016-10-10 21:43 UTC, Yosef Or Boczko
  Details

Description Yosef Or Boczko 2016-10-10 14:07:00 UTC
Created attachment 337317 [details]
Screenshot

I wants to see the keyboard shortcuts (in the keyboard shortcuts dialog)
from left to right, in RTL.
Now I see something like „T + Ctrl + Shift” or „F + Ctrl” (see screenshot).
I wants to see „Shift + Ctrl + T” and „Ctrl + F”.
Comment 1 Christian Hergert 2016-10-10 20:48:08 UTC
This is maintained in gtk+ now and so we need to fix it there.

Just to clarify, we only need to change the keyboard keys to always be RTL, not the text/keys box, right?
Comment 2 Christian Hergert 2016-10-10 20:54:19 UTC
Created attachment 337354 [details] [review]
always use LTR for shortcut accel

I haven't tested this, but I presume this is all that is needed.

Yosef, can you test this out and see if it meets your expectations?
Comment 3 Christian Hergert 2016-10-10 20:58:00 UTC
Created attachment 337355 [details] [review]
set LTR in instance init function of accel label

This is probably a better way to do it (in instance init function).
Comment 4 Yosef Or Boczko 2016-10-10 21:43:44 UTC
Created attachment 337375 [details]
Screenshot - with the patch

It look fine with your patch, I think it okay for me.
Thanks!
Comment 5 Christian Hergert 2016-10-10 22:14:23 UTC
Fixed on both 3-22 and master.