After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772655 - utils: Match any URI scheme
utils: Match any URI scheme
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-09 15:41 UTC by Florian Müllner
Modified: 2016-10-09 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
utils: Match any URI scheme (2.22 KB, patch)
2016-10-09 15:41 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-10-09 15:41:54 UTC 
See patch.
Comment 1 Florian Müllner 2016-10-09 15:41:58 UTC 
Created attachment 337278 [details] [review]
utils: Match any URI scheme

Since commit 651c71fed54, we don't use a fixed list of URI schemes
to linkify, but query the system for the list of supported schemes.
Unfortunately this requires access to the list of all installed
applications, which we don't have when running in a flatpak sandbox.
We could easily fix the 99% case by always adding http(s) to the
list, but as unsupported schemes should be extremely rare in the
wild, we can just live with the handful of false positives and
linkify any URI scheme.
Comment 2 Bastian Ilsø 2016-10-09 15:46:26 UTC 
Review of attachment 337278 [details] [review]:

looks good to me
Comment 3 Florian Müllner 2016-10-09 16:16:25 UTC 
Attachment 337278 [details] pushed as 094d7d1 - utils: Match any URI scheme