After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772615 - window-tracker: Consider Flatpak ID for window matching
window-tracker: Consider Flatpak ID for window matching
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 772614
Blocks:
 
 
Reported: 2016-10-08 16:24 UTC by Florian Müllner
Modified: 2016-10-10 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-tracker: Consider Flatpak ID for window matching (3.84 KB, patch)
2016-10-08 16:24 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-10-08 16:24:18 UTC 
See patch.
Comment 1 Florian Müllner 2016-10-08 16:24:23 UTC 
Created attachment 337243 [details] [review]
window-tracker: Consider Flatpak ID for window matching

Our window matching currently fails frequently with Flatpak
applications, as one of the primary hints used to link windows
with .desktop files - the WM_CLASS - no longer matches when
flatpak renames the exported .desktop file. Worse, as Flatpak
applications are run in their own PID namespace, different
apps frequently share a common _NET_WM_PID, resulting in
unrelated apps being grouped together by one of the fallback
paths. To match Flatpak applications reliably, take the newly
exported Flatpak ID into account.
Comment 2 Rui Matos 2016-10-10 20:33:07 UTC 
Review of attachment 337243 [details] [review]:

lgtm

::: src/shell-window-tracker.c
@@ +405,2 @@
   /* Check if the window has a GApplication ID attached; this is
    * canonical if it does

no longer canonical :-)
Comment 3 Florian Müllner 2016-10-10 22:59:11 UTC 
Attachment 337243 [details] pushed as 0c22a21 - window-tracker: Consider Flatpak ID for window matching