GNOME Bugzilla – Bug 772596
FLAC tag collision album/albumartist, artist/artistsort
Last modified: 2016-10-09 10:52:43 UTC
In the FLAC extractor, there's a large if/else if block to compare the tag names. FLAC tags are in the format "name=value", but the delimiter is not used in the comparison. The check for 'albumartist' is currently after the check for 'album' so is never reached, and ends up with the value for album being set to 'artist=[artist]' if it is encountered second. Also, some files contains an 'artistsort' tag which gives the artist name for sorting (e.g. last name first) which interferes with the artist tag. I've added the '=' delimiter to the tag name comparison for artist and album to fix this. None of the other tags clash as far as I know. PR here, along with an addition of the 'audio/flac' mimetype to the extractor rule, as it only has the experimental form right now: https://github.com/GNOME/tracker/pull/3
Thanks for the patch! I fetched it from your repo and pushed to master. The following fix has been pushed: 3be0725 Fix FLAC artist and album tag parsing, and add 'audio/flac' mime type to the extract rules.
Created attachment 337264 [details] [review] Fix FLAC artist and album tag parsing, and add 'audio/flac' mime type to the extract rules.