GNOME Bugzilla – Bug 772589
objectManager: handle proxies coming and going
Last modified: 2017-06-22 18:32:36 UTC
Ever since commit b8e29ae8c78658917c8a8ddd391667d7d9e36971 (I think), start up is littered with this message: Gjs-WARNING **: JS ERROR: could not get remote objects for service org.gnome.SettingsDaemon.Smartcard path since gnome-shell is now started before gnome-settings-daemon. This commit addresses the problem by making the object manager code not try to autostart its proxy, and instead wait for it to appear.
Created attachment 337197 [details] [review] objectManager: handle proxies coming and going
Note i haven't tested this yet, so consider it a draft. It probably has typos.
Will this work? The well-known name isn't registered anywhere, and the proxy flags look like they don't pass G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START. So auto-start would be attempted, and would fail (it's not running, and it doesn't know how to run it either).
Review of attachment 337197 [details] [review]: ::: js/misc/objectManager.js @@ +93,1 @@ the patch adds DO_NOT_AUTO_START here ↑ (granted, still not tested)
of course maybe the object manager should let the caller pass in flags, but right we only have one user of the object manager code so we should be fine with the simpler api for now.
Review of attachment 337197 [details] [review]: ::: js/misc/objectManager.js @@ +47,3 @@ g_name: this._serviceName, g_object_path: this._managerPath, g_flags: Gio.DBusProxyFlags.NONE }); How about this call?
(In reply to Bastien Nocera from comment #6) > How about this call? WOOPS
Created attachment 337522 [details] [review] objectManager: handle proxies coming and going Ever since commit b8e29ae8c78658917c8a8ddd391667d7d9e36971 (I think), start up is littered with this message: Gjs-WARNING **: JS ERROR: could not get remote objects for service org.gnome.SettingsDaemon.Smartcard path since gnome-shell is now started before gnome-settings-daemon. This commit addresses the problem by making the object manager code not try to autostart its proxy, and instead wait for it to appear.
(still untested)
I didn't do exhaustive testing, but the patch at least doesn't make the session crash, and I don't see the message in my log. Attachment 337522 [details] pushed as 1ef6262 - objectManager: handle proxies coming and going
Hello. I am now seeing this in journalctl when I alt-f2 -> r. Jan 10 00:19:05 hades gnome-shell[894]: JS ERROR: TypeError: this._dbusProxy is undefined ObjectManager<._onManagerProxyLoaded@resource:///org/gnome/shell/misc/objectManager.js:194:1 wrapper@resource:///org/gnome/gjs/modules/lang.js:178:13 Jan 10 00:19:06 hades gnome-shell[894]: GNOME Shell started at Tue Jan 10 2017 00:19:02 GMT+0200 (EET) I was told on irc that this is a regression from this bug. > ptomato> hussam, looks like a gnome-shell bug, regression from https://bugzilla.gnome.org/show_bug.cgi?id=772589 > I checked in the corresponding source file, https://github.com/GNOME/gnome-shell/blob/master/js/misc/objectManager.js, and _dbusProxy isn't defined anywhere > <hussam> Hussam Al-Tayeb ptomato: thank you. I will post in that bug.
those _dbusProxy's should say managerProxy, I think, but the fact that this is failing, makes me think that I botched the limited testing I did in comment 10, so I"m going to reopen, revert, and post a new patch and do more thorough testing before pushing.
Created attachment 343208 [details] [review] Revert "objectManager: handle proxies coming and going" This reverts commit 1ef626213952ea8568bb35ec0e96788a696d1fee.
Comment on attachment 343208 [details] [review] Revert "objectManager: handle proxies coming and going" Attachment 343208 [details] pushed as 2e332ff - Revert "objectManager: handle proxies coming and going"
See also https://bugzilla.gnome.org/show_bug.cgi?id=780403
*** Bug 778468 has been marked as a duplicate of this bug. ***
Created attachment 353777 [details] [review] objectManager: handle proxies coming and going Ever since commit b8e29ae8c78658917c8a8ddd391667d7d9e36971 (I think), start up is littered with this message: Gjs-WARNING **: JS ERROR: could not get remote objects for service org.gnome.SettingsDaemon.Smartcard path since gnome-shell is now started before gnome-settings-daemon. This commit addresses the problem by making the object manager code not try to autostart its proxy, and instead wait for it to appear.
this time tested on a machine with enable-smartcard-authentication == true !
Attachment 353777 [details] pushed as 9c8a470 - objectManager: handle proxies coming and going