After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772581 - wacom: Avoid warnings when switching VTs
wacom: Avoid warnings when switching VTs
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other All
: Normal normal
: ---
Assigned To: Carlos Garnacho
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-10-07 17:01 UTC by Bastien Nocera
Modified: 2016-10-08 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
common: Merge "if device" conditionals (973 bytes, patch)
2016-10-07 17:01 UTC, Bastien Nocera 		committed Details | Review
wacom: Avoid warnings when switching VTs (1.32 KB, patch)
2016-10-07 17:01 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-10-07 17:01:27 UTC 
And a little fix
Comment 1 Bastien Nocera 2016-10-07 17:01:31 UTC 
Created attachment 337181 [details] [review]
common: Merge "if device" conditionals

We have 2 checks for the same thing within a couple of lines. Merge
those.
Comment 2 Bastien Nocera 2016-10-07 17:01:36 UTC 
Created attachment 337182 [details] [review]
wacom: Avoid warnings when switching VTs

We get called for every removed GDK device, so check whether it's of
interest early, instead after throwing a bunch of warnings.

gsd-wacom[1884]: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
gsd-wacom[1884]: gsd_wacom_device_get_device_type: assertion 'GSD_IS_WACOM_DEVICE (device)' failed
gsd-wacom[1884]: gsd_wacom_device_get_settings: assertion 'GSD_IS_WACOM_DEVICE (device)' failed
gsd-wacom[1884]: invalid (NULL) pointer instance
Comment 3 Carlos Garnacho 2016-10-07 18:38:24 UTC 
Comment on attachment 337181 [details] [review]
common: Merge "if device" conditionals

Indeed.
Comment 4 Carlos Garnacho 2016-10-07 18:39:22 UTC 
Comment on attachment 337182 [details] [review]
wacom: Avoid warnings when switching VTs

Oops. Feel free to backport.
Comment 5 Bastien Nocera 2016-10-08 14:06:23 UTC 
Attachment 337181 [details] pushed as 62d3bf8 - common: Merge "if device" conditionals
Attachment 337182 [details] pushed as fd40e80 - wacom: Avoid warnings when switching VTs
Comment 6 Bastien Nocera 2016-10-08 14:09:34 UTC 
Also pushed to gnome-3-20, gnome-3-18 and gnome-3-16.