After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772579 - [review] device-factory as class and drop internal registration [th/device-factory-bgo772579]
[review] device-factory as class and drop internal registration [th/device-fa...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-07 16:34 UTC by Thomas Haller
Modified: 2016-10-11 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-10-07 16:34:04 UTC 
Make NMDeviceFactory a object, instead of an interface.

Also, drop the __attribute__((constructor)) to register internal device-factories.


Please review
Comment 1 Beniamino Galvani 2016-10-11 08:14:55 UTC 
> device: make NMDeviceFactory a class instead of an interface

+	NM_DEVICE_FACTORY_GET_CLASS (factory)->get_supported_types (factory,
+	                                                        out_link_types,
+	                                                        out_setting_types);

indention

Rest LGTM.