After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772559 - videorate: EOS and GAP handling fixes
videorate: EOS and GAP handling fixes
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-07 10:22 UTC by Andreas Frisch
Modified: 2018-11-03 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videorate: fix EOS handling when segment stop is unset (1.40 KB, patch)
2016-10-07 10:22 UTC, Andreas Frisch
none Details | Review
tests: add videorate EOS handling unit test (2.61 KB, patch)
2016-10-07 10:23 UTC, Andreas Frisch
none Details | Review
videorate: seperate buffer generation from transform_ip (9.63 KB, patch)
2016-10-07 10:23 UTC, Andreas Frisch
none Details | Review
videorate: use advance function to bridge gaps with repeated buffers (2.45 KB, patch)
2016-10-07 10:24 UTC, Andreas Frisch
none Details | Review
tests: add videorate GAP event handling unit test (2.14 KB, patch)
2016-10-07 10:24 UTC, Andreas Frisch
none Details | Review
seperate buffer generation from transform_ip (9.66 KB, patch)
2016-10-07 13:31 UTC, Andreas Frisch
none Details | Review
videorate: use advance function to bridge gaps with repeated buffers (2.47 KB, patch)
2016-10-07 13:32 UTC, Andreas Frisch
none Details | Review

Description Andreas Frisch 2016-10-07 10:22:49 UTC
Created attachment 337149 [details] [review]
videorate: fix EOS handling when segment stop is unset

videorate only drops GAP events instead of using the opportunity to fill until the start of the gap.

videorate doesn't handle EOS correctly when there is no segment stop set.

patches follow
Comment 1 Andreas Frisch 2016-10-07 10:23:10 UTC
Created attachment 337150 [details] [review]
tests: add videorate EOS handling unit test
Comment 2 Andreas Frisch 2016-10-07 10:23:32 UTC
Created attachment 337151 [details] [review]
videorate: seperate buffer generation from transform_ip
Comment 3 Andreas Frisch 2016-10-07 10:24:13 UTC
Created attachment 337152 [details] [review]
videorate: use advance function to bridge gaps with repeated buffers
Comment 4 Andreas Frisch 2016-10-07 10:24:37 UTC
Created attachment 337153 [details] [review]
tests: add videorate GAP event handling unit test
Comment 5 Andreas Frisch 2016-10-07 13:31:39 UTC
Created attachment 337169 [details] [review]
seperate buffer generation from transform_ip

The new advance function will be used by the gap event handling.
Comment 6 Andreas Frisch 2016-10-07 13:32:14 UTC
Created attachment 337170 [details] [review]
videorate: use advance function to bridge gaps with repeated buffers
Comment 7 Andreas Frisch 2016-10-07 13:35:16 UTC
we fixed up some of the patches so that it checks for non-existing prevbuf,

clarification of the order of patches:

1. https://bugzilla.gnome.org/attachment.cgi?id=337149
2. https://bugzilla.gnome.org/attachment.cgi?id=337150
3. https://bugzilla.gnome.org/attachment.cgi?id=337169
4. https://bugzilla.gnome.org/attachment.cgi?id=337170
5. https://bugzilla.gnome.org/attachment.cgi?id=337153
Comment 8 GStreamer system administrator 2018-11-03 11:50:33 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/298.