After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772554 - libs: minor correction for logical consistency
libs: minor correction for logical consistency
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other All
: Normal minor
: 1.10.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-07 09:59 UTC by Hyunjun Ko
Modified: 2016-10-31 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libs: minor correction for logical consistency (4.40 KB, patch)
2016-10-07 10:00 UTC, Hyunjun Ko
none Details | Review
libs: minor correction for logical consistency (6.09 KB, patch)
2016-10-12 06:27 UTC, Hyunjun Ko
committed Details | Review

Description Hyunjun Ko 2016-10-07 09:59:34 UTC
There are some logically invalid ref/unref methods, which are being used.

1. GstVaapiDecoder is inherited from GstVaapiMiniObject.
But it call gst_vaapi_object_replace instead of gst_vaapi_mini_object_replace

2. GstVaapiPixmap,Window,Texture are inherited from GstVaapiObject.
But it call gst_vaapi_mini_object_ref/unref/replace directly.

These are not critical because gst_vaapi_object_ref/unref/replace calls gst_vaapi_mini_object_ref/unref/replace directly.

But for consistency, we should change this, IMO.
Especially for 1, it should be changed.
Comment 1 Hyunjun Ko 2016-10-07 10:00:31 UTC
Created attachment 337139 [details] [review]
libs: minor correction for logical consistency
Comment 2 Víctor Manuel Jáquez Leal 2016-10-08 12:10:59 UTC
Review of attachment 337139 [details] [review]:

lgtm. 

Not sure if we should apply it now or after release, since it is just consistency, and it will be modified when gstobjectivation advance.
Comment 3 Hyunjun Ko 2016-10-12 06:27:57 UTC
Created attachment 337493 [details] [review]
libs: minor correction for logical consistency

Added a case of gstvaapiencoder
Comment 4 Hyunjun Ko 2016-10-12 06:30:45 UTC
(In reply to Víctor Manuel Jáquez Leal from comment #2)
> Review of attachment 337139 [details] [review] [review]:
> 
> lgtm. 
> 
> Not sure if we should apply it now or after release, since it is just
> consistency, and it will be modified when gstobjectivation advance.

It's okay of merge after release.
And I think it'd be better to be seperated from gstobject conversion.
Comment 5 Víctor Manuel Jáquez Leal 2016-10-25 09:38:31 UTC
Attachment 337493 [details] pushed as abc2480 - libs: minor correction for logical consistency
Comment 6 Hyunjun Ko 2016-10-28 06:28:58 UTC
Victor, thanx for merge but I found the thing about gstvaapiencoder is dropped on git.
Probably, you merged the first patch instead of the second patch :)