After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772530 - Make password autofill compatible with Angular forms
Make password autofill compatible with Angular forms
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-06 20:58 UTC by Michael Catanzaro
Modified: 2016-11-03 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make password autofill compatible with Angular forms (2.28 KB, patch)
2016-10-06 20:58 UTC, Michael Catanzaro
none Details | Review
Make password autofill compatible with Angular forms (2.48 KB, patch)
2016-10-11 19:30 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-10-06 20:58:46 UTC
Make password autofill compatible with Angular forms
Comment 1 Michael Catanzaro 2016-10-06 20:58:49 UTC
Created attachment 337110 [details] [review]
Make password autofill compatible with Angular forms
Comment 2 Gustavo Noronha (kov) 2016-10-07 15:31:49 UTC
Review of attachment 337110 [details] [review]:

LGTM
Comment 3 Carlos Garcia Campos 2016-10-10 06:04:08 UTC
Review of attachment 337110 [details] [review]:

Please, explain in the commit message why this makes passwords work in Angular forms. Commit now, of course means commit when 2.14.1 is out.
Comment 4 Michael Catanzaro 2016-10-10 13:40:32 UTC
(In reply to Carlos Garcia Campos from comment #3)
> Review of attachment 337110 [details] [review] [review]:
> 
> Please, explain in the commit message why this makes passwords work in
> Angular forms.

I didn't explain it because I have no clue what I've done. :D  I just added the function calls that Dape says Chromium uses.
Comment 5 Michael Catanzaro 2016-10-11 19:30:29 UTC
Created attachment 337461 [details] [review]
Make password autofill compatible with Angular forms

Honestly, I have no clue what I've done here, but it's what Chromium
does when it autofills a form, and it makes an Angular password form
work on one of our internal sites, so it's probably good right?
Comment 6 Carlos Garcia Campos 2016-10-12 06:19:18 UTC
Wait, I forgot to merge the new api patch in 2.14.1 :-( we will have to wait until 2.14.2, I'm sorry.
Comment 7 Michael Catanzaro 2016-10-12 16:18:21 UTC
Yup, I noticed... not a big deal; it would be great if it's in 2.14.2, though, whenever that is.
Comment 8 Michael Catanzaro 2016-10-12 16:18:59 UTC
It's not really a simple merge anyway, right? Since the bindings are still autogenerated in 2.14, I don't even know how to do it. :)
Comment 9 Carlos Garcia Campos 2016-10-13 06:47:14 UTC
(In reply to Michael Catanzaro from comment #8)
> It's not really a simple merge anyway, right? Since the bindings are still
> autogenerated in 2.14, I don't even know how to do it. :)

Right, I'll do it, don't worry
Comment 10 Sergio Villar 2016-10-26 18:58:33 UTC
Do we still need the 

g_object_set (username_node, "value", username, NULL);
g_object_set (password_node, "value", password, NULL);

I don't think so.
Comment 11 Michael Catanzaro 2016-10-26 21:31:57 UTC
(In reply to Sergio Villar from comment #10)
> Do we still need the 
> 
> g_object_set (username_node, "value", username, NULL);
> g_object_set (password_node, "value", password, NULL);
> 
> I don't think so.

You're right! I've pushed a follow-up.
Comment 12 Michael Catanzaro 2016-11-03 15:21:35 UTC
OK, backported all of this to gnome-3-22 since WebKitGTK+ 2.14.2 is out. Thanks both of you!